netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Subject: kmemleak in flowtable xdp
Date: Wed, 9 Oct 2024 11:39:51 +0200	[thread overview]
Message-ID: <ZwZPZ_xguhEchEv0@calendula> (raw)

Hi Lorenzo,

kmemleak is not happy here when running tests:

    [<00000000be65a589>] __kmalloc_cache_noprof+0x280/0x310
    [<00000000c6569ad4>] nf_flow_offload_xdp_setup+0x70/0x8d0 [nf_flow_table]
    [<000000001efe6e35>] nf_flow_table_offload_setup+0x324/0x610 [nf_flow_table]
    [<000000005d9c9ad6>] nft_register_flowtable_net_hooks+0x3f4/0x890 [nf_tables]
    [<00000000de9071ee>] nf_tables_newflowtable+0xf61/0x18c0 [nf_tables]
    [<00000000924f5d86>] nfnetlink_rcv_batch+0x12c1/0x1c50 [nfnetlink]
    [<000000003fa07104>] nfnetlink_rcv+0x2a3/0x320 [nfnetlink]
    [<000000009fd1c990>] netlink_unicast+0x588/0x7f0
    [<00000000ee126795>] netlink_sendmsg+0x702/0xba0
    [<000000000ddf29fb>] ____sys_sendmsg+0x7cd/0x9a0
    [<0000000027b80416>] ___sys_sendmsg+0xd6/0x140
    [<00000000edfe1eb5>] __sys_sendmsg+0xba/0x150
    [<000000009d5eb571>] do_syscall_64+0x47/0x110
    [<0000000077c3a21e>] entry_SYSCALL_64_after_hwframe+0x76/0x7e

nf_flow_offload_xdp_setup+0x70

56
57              ft_elem = kzalloc(sizeof(*ft_elem), GFP_KERNEL_ACCOUNT);
58              if (!ft_elem)
59                      return -ENOMEM;
60
61              ft_elem->ft = ft; <--- HERE
62
63              mutex_lock(&nf_xdp_hashtable_lock);
64
65              hash_for_each_possible(nf_xdp_hashtable,

Thanks.

                 reply	other threads:[~2024-10-09  9:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwZPZ_xguhEchEv0@calendula \
    --to=pablo@netfilter.org \
    --cc=bpf@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).