From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DCA217BB0C for ; Wed, 9 Oct 2024 21:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728510149; cv=none; b=ogUcat7SufT3oEVoW/IBxhfZ3fvcY7uLc4nw4VmKS9VUN0jIB5t9t4II4ZkAga5evXOugFF+o4YDIcbcVP0zwmwJBZwFqHWzKJidV8SZfJG5B4GKtYSLtRikUp+T2rwnXrqfIds8er5fIJM8I1IsxqaMWSQoXxywmk3SqDGG9AE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728510149; c=relaxed/simple; bh=ppflntTAWpe6pyrUulRN0IEktwLeGX9dBx/Bry9CEiQ=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=db1d12mYoUHN4mD67b2DRftmAETcZlGO7ZOxVjFQqWTE6Ds8kmXdLFQCCDEZLNPB+k19mXOfo0oLTVfTgGEKJ1StL3hzJmnE+E2cGfcRoQWRKUP1dHE8aaRSZWovAw0WYLDpZ5Bq4th1toJBju6Ux+nCWaVuoH6eNQFMOGUlnxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=WofvFC0n; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="WofvFC0n" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7ea0728475dso238768a12.0 for ; Wed, 09 Oct 2024 14:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1728510146; x=1729114946; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=as6o/zgw0W0ImJI8bO9wBqO654a1TD8C3ivRXpJtgxI=; b=WofvFC0nP9g3lZrryZK7bwxUrX4VRSDcSAMfLaqOj4T07U+2Ukxp4B4s/eMy4Zke6q EcfQUEmqOMT9W6fW07+lRaEQYsnhvJ2530Ge8Mj/08lgXzeq705y++Sv3u1CkA01IiqA qIvG5IjYBhmz0CaWvUWtNP/th+2dHQMK6JZCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728510146; x=1729114946; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=as6o/zgw0W0ImJI8bO9wBqO654a1TD8C3ivRXpJtgxI=; b=ZPGH3aSnjMFNxOvNU8OSoteFvIoI8XSv+VX+wAGS70up3UsIjZL2N5I7FLapxujw7W teT+EgdTCji7mw4n9VgtqcSoDL0srfLBrTP0IVLrI0/yr01ypCps0ggJYsc/JjBmP618 ax3oCXOI1jltNUHZYiGylVExcXxKgU+Y446Sq9f2H+vDILHUTIEGKzd1zGoK6yq9Auj0 1YL5YsvmVaDTy7uQYb0ZZnn44uOaubaQX8eJud2nvg7kwKoYF5u3cC2U1FpSIJYR1kjR vLj/zrZnrtwEct66ai6AmciYyyHAPXaeq48CtM0BfWL8eoKm4CRUxqj/l9skkYfNzhyz sQyQ== X-Forwarded-Encrypted: i=1; AJvYcCXh9JBfqDlduH/tS6270sl0INjgQNQMJuUuCvEn5S7A5cOFknsfNYSqMdBaVKG6JGtS+XZZnVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YySVnsuWqIbBGPEQ6uxjrWr/+g0zoIjZdxEJjoxzvEAJrn5GdV1 ZzL2EZpC3oSgz3kTA+7VhZKdH//tNysiRHIjEKnnSRAurABHZWXDkOZTba2F0VQ= X-Google-Smtp-Source: AGHT+IGqLj43orHfRVrzKFauhS+4NPdIZ/yjJUa0XH7LCnLtPQ+KHfsPGcffCRXh0Js5Dgc3Kmpt1Q== X-Received: by 2002:a05:6a21:1192:b0:1cf:2d22:3ec4 with SMTP id adf61e73a8af0-1d8ae11eb83mr1271564637.25.1728510146591; Wed, 09 Oct 2024 14:42:26 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71df0cbc4b9sm8503914b3a.17.2024.10.09.14.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 14:42:26 -0700 (PDT) Date: Wed, 9 Oct 2024 14:42:22 -0700 From: Joe Damato To: Jijie Shao , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shenjian15@huawei.com, wangpeiyang1@huawei.com, liuyonglong@huawei.com, chenhao418@huawei.com, sudongming1@huawei.com, xujunsheng@huawei.com, shiyongbang@huawei.com, libaihan@huawei.com, andrew@lunn.ch, horms@kernel.org, kalesh-anakkur.purayil@broadcom.com, christophe.jaillet@wanadoo.fr, jonathan.cameron@huawei.com, shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V11 net-next 07/10] net: hibmcge: Implement rx_poll function to receive packets Message-ID: Mail-Followup-To: Joe Damato , Jijie Shao , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shenjian15@huawei.com, wangpeiyang1@huawei.com, liuyonglong@huawei.com, chenhao418@huawei.com, sudongming1@huawei.com, xujunsheng@huawei.com, shiyongbang@huawei.com, libaihan@huawei.com, andrew@lunn.ch, horms@kernel.org, kalesh-anakkur.purayil@broadcom.com, christophe.jaillet@wanadoo.fr, jonathan.cameron@huawei.com, shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241008022358.863393-1-shaojijie@huawei.com> <20241008022358.863393-8-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Oct 09, 2024 at 02:35:58PM -0700, Joe Damato wrote: > On Tue, Oct 08, 2024 at 10:23:55AM +0800, Jijie Shao wrote: > > Implement rx_poll function to read the rx descriptor after > > receiving the rx interrupt. Adjust the skb based on the > > descriptor to complete the reception of the packet. > > > > Signed-off-by: Jijie Shao > > [...] > > > + > > +static int hbg_napi_rx_poll(struct napi_struct *napi, int budget) > > +{ > > [...] > > > + > > + if (likely(packet_done < budget && > > + napi_complete_done(napi, packet_done))) > > + hbg_hw_irq_enable(priv, HBG_INT_MSK_RX_B, true); > > I am not sure this is correct. > > napi_complete_done might return false if napi_defer_hard_irqs is > being used [1]. > > In that case you'd probably want to avoid re-enabling IRQs even > though (packet_done < budget) is true. Err, sorry. I read the code wrong. The implementation you have looks right to me, my mistake.