From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BD9C3207; Fri, 18 Oct 2024 12:36:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729255006; cv=none; b=n+d3zUfsULLGiJFt0Jyr1FfEbbkpuU47CB5HeYVbVSp9kZiJKW5dB52izR1d2o3p/1OXZ3dFRmskk352Kev8/RpWWfJXRIwl33CmeIk+HW6onrxT+ZynEtFbfGr/REio3CXiOPcTwgeSY/31QDhpfIVtrnAU+SDm1QJW+nMMPmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729255006; c=relaxed/simple; bh=tyMewtQqpHxg4qbfOy5HqA9327malShWrnPYHfuO2vg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K/jnKojaQEjhdZ/dbrb9d/GchnYJJJw6g0bQTaJq9dbjPoeDN1Q1T+tJrIu4n8xVUa3WhUJ/QEb2D/8rF1M/Cn3oIyg7wxjThN8X80+QMaGyxTT1ZiWlKbwq9443LC/rUnC91mKQTvGfmPKEI2k0ctFApUDN058gDswlTV7Wkho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: 0cXE/RMeS8il+576EWH2vg== X-CSE-MsgGUID: r0T/vuPmQYqRHeav2DZvew== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="39326594" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="39326594" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 05:36:45 -0700 X-CSE-ConnectionGUID: m9kwGWSOS+q+2j/CwHgoLQ== X-CSE-MsgGUID: Ks+uPRRJR+C757twukfZZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208";a="79663802" Received: from smile.fi.intel.com ([10.237.72.154]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 05:36:39 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1t1mDa-00000004Sex-2cSq; Fri, 18 Oct 2024 15:36:34 +0300 Date: Fri, 18 Oct 2024 15:36:34 +0300 From: Andy Shevchenko To: Philipp Stanner Cc: Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Richard Cochran , Damien Le Moal , Hannes Reinecke , Chaitanya Kulkarni , Al Viro , Li Zetao , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v8 2/6] PCI: Deprecate pcim_iounmap_regions() Message-ID: References: <20241016094911.24818-2-pstanner@redhat.com> <20241016094911.24818-4-pstanner@redhat.com> <0cf0ffed63a8645c49f043877c526b2ab0abf96e.camel@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0cf0ffed63a8645c49f043877c526b2ab0abf96e.camel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Oct 18, 2024 at 12:52:15PM +0200, Philipp Stanner wrote: > On Wed, 2024-10-16 at 13:38 +0300, Andy Shevchenko wrote: > > On Wed, Oct 16, 2024 at 11:49:05AM +0200, Philipp Stanner wrote: ... > > > + * This function is DEPRECATED. Do not use it in new code. > > > > Interestingly that the syntax of the DEPRECATED is not documented > > (yet?), > > however the sphinx parser hints us about **DEPRECATED** format — see > > Documentation/sphinx/parse-headers.pl:251. In any case the above > > seems > > like second used (in a form of the full sentence) and will be updated > > in accordance with the above mentioned script. > > Can't completely follow – so one should always write "**DEPRECATED**", > correct? I can't answer to this, because there may be "rendered" form and in this case it should not be surrounded by double asterisks, otherwise it's better to have at the start. > Is that a blocker for you? Nope, I mentioned this in the last sentence in my previous reply. > All the docstrings in pci/pci.c and pci/devres.c so far just use > "DEPRECATED". Yeah, this, if ever needed, has to be changed at once. -- With Best Regards, Andy Shevchenko