From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ilya Katsnelson <me@0upti.me>
Cc: Sasha Levin <sashal@kernel.org>,
netdev@vger.kernel.org, Phil Sutter <phil@nwl.cc>,
linux-kernel@vger.kernel.org,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Eric Dumazet <edumazet@google.com>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
ignat@cloudflare.com, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [netfilter-core] [PATCH v2] netfilter: xtables: fix typo causing some targets to not load on IPv6
Date: Sat, 19 Oct 2024 23:10:16 +0200 [thread overview]
Message-ID: <ZxQgOCqORNuAhltX@calendula> (raw)
In-Reply-To: <ZxP2FUVCmettzj7B@calendula>
On Sat, Oct 19, 2024 at 08:10:29PM +0200, Pablo Neira Ayuso wrote:
> Hi,
>
> Thanks for your patch.
>
> On Sat, Oct 19, 2024 at 08:05:07AM +0300, Ilya Katsnelson wrote:
> > These were added with the wrong family in 4cdc55e, which seems
> > to just have been a typo, but now ip6tables rules with --set-mark
> > don't work anymore, which is pretty bad.
>
> There is at least one more issue, TRACE is missing this chunk:
>
> diff --git a/net/netfilter/xt_TRACE.c b/net/netfilter/xt_TRACE.c
> index f3fa4f11348c..a642ff09fc8e 100644
> --- a/net/netfilter/xt_TRACE.c
> +++ b/net/netfilter/xt_TRACE.c
> @@ -49,6 +49,7 @@ static struct xt_target trace_tg_reg[] __read_mostly = {
> .target = trace_tg,
> .checkentry = trace_tg_check,
> .destroy = trace_tg_destroy,
> + .me = THIS_MODULE,
> },
> #endif
> };
I will post a v2 including this chunk.
Thanks.
prev parent reply other threads:[~2024-10-19 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 5:05 [PATCH v2] netfilter: xtables: fix typo causing some targets to not load on IPv6 Ilya Katsnelson
2024-10-19 18:10 ` Pablo Neira Ayuso
2024-10-19 21:10 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxQgOCqORNuAhltX@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ignat@cloudflare.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@0upti.me \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@nwl.cc \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).