From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ignat Korchagin <ignat@cloudflare.com>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@cloudflare.com, stable@vger.kernel.org
Subject: Re: [PATCH net] netfilter: xtables: fix a bad copypaste in xt_nflog module
Date: Sat, 19 Oct 2024 23:15:47 +0200 [thread overview]
Message-ID: <ZxQhg-aU1cPSoVCU@calendula> (raw)
In-Reply-To: <20241018162517.39154-1-ignat@cloudflare.com>
On Fri, Oct 18, 2024 at 05:25:17PM +0100, Ignat Korchagin wrote:
> For the nflog_tg_reg struct under the CONFIG_IP6_NF_IPTABLES switch
> family should probably be NFPROTO_IPV6
Patch is not complete.
I will post a version including mark and TRACE too
> Fixes: 0bfcb7b71e73 ("netfilter: xtables: avoid NFPROTO_UNSPEC where needed")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
> ---
> net/netfilter/xt_NFLOG.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/xt_NFLOG.c b/net/netfilter/xt_NFLOG.c
> index d80abd6ccaf8..6dcf4bc7e30b 100644
> --- a/net/netfilter/xt_NFLOG.c
> +++ b/net/netfilter/xt_NFLOG.c
> @@ -79,7 +79,7 @@ static struct xt_target nflog_tg_reg[] __read_mostly = {
> {
> .name = "NFLOG",
> .revision = 0,
> - .family = NFPROTO_IPV4,
> + .family = NFPROTO_IPV6,
> .checkentry = nflog_tg_check,
> .destroy = nflog_tg_destroy,
> .target = nflog_tg,
> --
> 2.39.5
>
prev parent reply other threads:[~2024-10-19 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 16:25 [PATCH net] netfilter: xtables: fix a bad copypaste in xt_nflog module Ignat Korchagin
2024-10-19 21:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxQhg-aU1cPSoVCU@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=ignat@cloudflare.com \
--cc=kadlec@netfilter.org \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).