* [PATCH net] netfilter: xtables: fix a bad copypaste in xt_nflog module
@ 2024-10-18 16:25 Ignat Korchagin
2024-10-19 21:15 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Ignat Korchagin @ 2024-10-18 16:25 UTC (permalink / raw)
To: Pablo Neira Ayuso, Jozsef Kadlecsik, davem, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Florian Westphal, netfilter-devel,
coreteam, netdev, linux-kernel
Cc: kernel-team, Ignat Korchagin, stable
For the nflog_tg_reg struct under the CONFIG_IP6_NF_IPTABLES switch
family should probably be NFPROTO_IPV6
Fixes: 0bfcb7b71e73 ("netfilter: xtables: avoid NFPROTO_UNSPEC where needed")
Cc: stable@vger.kernel.org
Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
---
net/netfilter/xt_NFLOG.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/xt_NFLOG.c b/net/netfilter/xt_NFLOG.c
index d80abd6ccaf8..6dcf4bc7e30b 100644
--- a/net/netfilter/xt_NFLOG.c
+++ b/net/netfilter/xt_NFLOG.c
@@ -79,7 +79,7 @@ static struct xt_target nflog_tg_reg[] __read_mostly = {
{
.name = "NFLOG",
.revision = 0,
- .family = NFPROTO_IPV4,
+ .family = NFPROTO_IPV6,
.checkentry = nflog_tg_check,
.destroy = nflog_tg_destroy,
.target = nflog_tg,
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] netfilter: xtables: fix a bad copypaste in xt_nflog module
2024-10-18 16:25 [PATCH net] netfilter: xtables: fix a bad copypaste in xt_nflog module Ignat Korchagin
@ 2024-10-19 21:15 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2024-10-19 21:15 UTC (permalink / raw)
To: Ignat Korchagin
Cc: Jozsef Kadlecsik, davem, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Florian Westphal, netfilter-devel, coreteam, netdev,
linux-kernel, kernel-team, stable
On Fri, Oct 18, 2024 at 05:25:17PM +0100, Ignat Korchagin wrote:
> For the nflog_tg_reg struct under the CONFIG_IP6_NF_IPTABLES switch
> family should probably be NFPROTO_IPV6
Patch is not complete.
I will post a version including mark and TRACE too
> Fixes: 0bfcb7b71e73 ("netfilter: xtables: avoid NFPROTO_UNSPEC where needed")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
> ---
> net/netfilter/xt_NFLOG.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/xt_NFLOG.c b/net/netfilter/xt_NFLOG.c
> index d80abd6ccaf8..6dcf4bc7e30b 100644
> --- a/net/netfilter/xt_NFLOG.c
> +++ b/net/netfilter/xt_NFLOG.c
> @@ -79,7 +79,7 @@ static struct xt_target nflog_tg_reg[] __read_mostly = {
> {
> .name = "NFLOG",
> .revision = 0,
> - .family = NFPROTO_IPV4,
> + .family = NFPROTO_IPV6,
> .checkentry = nflog_tg_check,
> .destroy = nflog_tg_destroy,
> .target = nflog_tg,
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-19 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 16:25 [PATCH net] netfilter: xtables: fix a bad copypaste in xt_nflog module Ignat Korchagin
2024-10-19 21:15 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).