From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 0/3] net: phylink: simplify SFP PHY attachment
Date: Tue, 22 Oct 2024 12:59:44 +0100 [thread overview]
Message-ID: <ZxeTsApaFCIjl5RH@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241022135447.391b6f59@device-21.home>
On Tue, Oct 22, 2024 at 01:54:47PM +0200, Maxime Chevallier wrote:
> Hello Russell,
>
> On Tue, 22 Oct 2024 12:39:06 +0100
> "Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
>
> > Hi,
> >
> > These two patches simplify how we attach SFP PHYs.
> >
> > The first patch notices that at the two sites where we call
> > sfp_select_interface(), if that fails, we always print the same error.
> > Move this into its own function.
> >
> > The second patch adds an additional level of validation, checking that
> > the returned interface is one that is supported by the MAC/PCS.
> >
> > The last patch simplifies how SFP PHYs are attached, reducing the
> > number of times that we do validation in this path.
> >
> > drivers/net/phy/phylink.c | 82 ++++++++++++++++++++++++-----------------------
> > 1 file changed, 42 insertions(+), 40 deletions(-)
>
> It looks like the patches didn't make it through, there're also not on
> lore nor patchwork :(
You're too quick. I was delaying the patches for two reasons:
1) to ensure Jakub's nipa bot bug doesn't get me again.
2) build-testing the series, as I'd made a change... and unsurprisingly
not waiting for that to finish, and sending the patches, immediately
after sending it found a problem. :(
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2024-10-22 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 11:39 [PATCH net-next 0/3] net: phylink: simplify SFP PHY attachment Russell King (Oracle)
2024-10-22 11:54 ` [PATCH net-next 1/3] net: phylink: add common validation for sfp_select_interface() Russell King (Oracle)
2024-10-22 13:47 ` Maxime Chevallier
2024-10-22 11:54 ` [PATCH net-next 2/3] net: phylink: validate sfp_select_interface() returned interface Russell King (Oracle)
2024-10-22 13:47 ` Maxime Chevallier
2024-10-22 11:54 ` [PATCH net-next 3/3] net: phylink: simplify how SFP PHYs are attached Russell King (Oracle)
2024-10-22 11:58 ` Russell King (Oracle)
2024-10-22 13:49 ` Maxime Chevallier
2024-10-22 11:54 ` [PATCH net-next 0/3] net: phylink: simplify SFP PHY attachment Maxime Chevallier
2024-10-22 11:59 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxeTsApaFCIjl5RH@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).