From: Johnny Park <pjohnny0508@gmail.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: horms@kernel.org, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
andrew@lunn.ch, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] [net-next] igb: Fix spelling in igb_main.c
Date: Wed, 23 Oct 2024 22:51:34 -0600 [thread overview]
Message-ID: <ZxnSVuqlXCHgeVKr@Fantasy-Ubuntu> (raw)
In-Reply-To: <ba58bbcd-079e-42b9-8e66-52b2626936e2@molgen.mpg.de>
On Wed, Oct 23, 2024 at 10:04:45AM +0200, Paul Menzel wrote:
> Dear Johnny,
>
>
> Thank you for your patch. I recommend to put the information, that the typos
> are only in comments, to the summary/title:
>
> igb: Fix 2 typos in comments in igb_main.c
>
> That way, skimming `git log --oneline` is more informative.
>
> Am 23.10.24 um 05:21 schrieb Johnny Park:
> > Simple patch that fix spelling mistakes in igb_main.c
>
> fix*es*, but better use imperative mood:
>
> Fix 2 spelling mistakes in comments `igb_main.c`.
>
Hello Paul,
I appreciate your comments, I'll address those in the new patch shortly.
Thanks,
Johnny
next prev parent reply other threads:[~2024-10-24 4:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 3:21 [PATCH v2 1/1] [net-next] igb: Fix spelling in igb_main.c Johnny Park
2024-10-23 8:04 ` [Intel-wired-lan] " Paul Menzel
2024-10-24 4:51 ` Johnny Park [this message]
2024-10-23 12:02 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxnSVuqlXCHgeVKr@Fantasy-Ubuntu \
--to=pjohnny0508@gmail.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).