[GIT PULL] Networking for v6.12-rc5

[GIT PULL] Networking for v6.12-rc5

[Paolo Abeni]

Hi Linus!

Oddily this includes a fix for posix clock regression; in our previous PR
we included a change there as a pre-requisite for networking one.
Such fix proved to be buggy and requires the follow-up included here.
Thomas suggested we should send it, given we sent the buggy patch.

The following changes since commit 07d6bf634bc8f93caf8920c9d61df761645336e2:

  Merge tag 'net-6.12-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2024-10-17 09:31:18 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git net-6.12-rc5

for you to fetch changes up to 9efc44fb2dba6138b0575826319200049078679a:

  Merge branch 'net-dsa-mv88e6xxx-fix-mv88e6393x-phc-frequency-on-internal-clock' (2024-10-24 12:57:48 +0200)

----------------------------------------------------------------
Including fixes from netfiler, xfrm and bluetooth.

Current release - regressions:

  - posix-clock: Fix unbalanced locking in pc_clock_settime()

  - netfilter: fix typo causing some targets not to load on IPv6

Current release - new code bugs:

  - xfrm: policy: remove last remnants of pernet inexact list

Previous releases - regressions:

  - core: fix races in netdev_tx_sent_queue()/dev_watchdog()

  - bluetooth: fix UAF on sco_sock_timeout

  - eth: hv_netvsc: fix VF namespace also in synthetic NIC NETDEV_REGISTER event

  - eth: usbnet: fix name regression

  - eth: be2net: fix potential memory leak in be_xmit()

  - eth: plip: fix transmit path breakage

Previous releases - always broken:

  - sched: deny mismatched skip_sw/skip_hw flags for actions created by classifiers

  - netfilter: bpf: must hold reference on net namespace

  - eth: virtio_net: fix integer overflow in stats

  - eth: bnxt_en: replace ptp_lock with irqsave variant

  - eth: octeon_ep: add SKB allocation failures handling in __octep_oq_process_rx()

Misc:

  - MAINTAINERS: add Simon as an official reviewer

Signed-off-by: Paolo Abeni <pabeni@redhat.com>

----------------------------------------------------------------
Aleksandr Mishin (4):
      octeon_ep: Implement helper for iterating packets in Rx queue
      octeon_ep: Add SKB allocation failures handling in __octep_oq_process_rx()
      fsl/fman: Save device references taken in mac_probe()
      fsl/fman: Fix refcount handling of fman-related devices

Dmitry Antipov (2):
      net: sched: fix use-after-free in taprio_change()
      net: sched: use RCU read-side critical section in taprio_dump()

Eric Dumazet (1):
      net: fix races in netdev_tx_sent_queue()/dev_watchdog()

Eyal Birger (2):
      xfrm: extract dst lookup parameters into a struct
      xfrm: respect ip protocols rules criteria when performing dst lookups

Florian Westphal (2):
      xfrm: policy: remove last remnants of pernet inexact list
      netfilter: bpf: must hold reference on net namespace

Haiyang Zhang (1):
      hv_netvsc: Fix VF namespace also in synthetic NIC NETDEV_REGISTER event

Hangbin Liu (1):
      MAINTAINERS: add samples/pktgen to NETWORKING [GENERAL]

Heiner Kallweit (1):
      r8169: avoid unsolicited interrupts

Jakub Boehm (1):
      net: plip: fix break; causing plip to never transmit

Jakub Kicinski (1):
      MAINTAINERS: add Simon as an official reviewer

Jesper Dangaard Brouer (1):
      mailmap: update entry for Jesper Dangaard Brouer

Jinjie Ruan (1):
      posix-clock: posix-clock: Fix unbalanced locking in pc_clock_settime()

Kory Maincent (1):
      net: pse-pd: Fix out of bound for loop

Lin Ma (1):
      net: wwan: fix global oob in wwan_rtnl_policy

Luiz Augusto von Dentz (3):
      Bluetooth: hci_core: Disable works on hci_unregister_dev
      Bluetooth: SCO: Fix UAF on sco_sock_timeout
      Bluetooth: ISO: Fix UAF on iso_sock_timeout

Michael S. Tsirkin (1):
      virtio_net: fix integer overflow in stats

Michel Alex (1):
      net: phy: dp83822: Fix reset pin definitions

Oliver Neukum (1):
      net: usb: usbnet: fix name regression

Pablo Neira Ayuso (1):
      netfilter: xtables: fix typo causing some targets not to load on IPv6

Paolo Abeni (5):
      Merge branch 'fsl-fman-fix-refcount-handling-of-fman-related-devices'
      Merge tag 'nf-24-10-21' of git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf
      Merge tag 'ipsec-2024-10-22' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec
      Merge tag 'for-net-2024-10-23' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth
      Merge branch 'net-dsa-mv88e6xxx-fix-mv88e6393x-phc-frequency-on-internal-clock'

Peter Rashleigh (1):
      net: dsa: mv88e6xxx: Fix error when setting port policy on mv88e6393x

Petr Vaganov (1):
      xfrm: fix one more kernel-infoleak in algo dumping

Reinhard Speyerer (1):
      net: usb: qmi_wwan: add Fibocom FG132 0x0112 composition

Sabrina Dubroca (1):
      xfrm: validate new SA's prefixlen using SA family when sel.family is unset

Shenghao Yang (3):
      net: dsa: mv88e6xxx: group cycle counter coefficients
      net: dsa: mv88e6xxx: read cycle counter period from hardware
      net: dsa: mv88e6xxx: support 4000ps cycle counter period

Tim Harvey (1):
      net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x

Vadim Fedorenko (1):
      bnxt_en: replace ptp_lock with irqsave variant

Vladimir Oltean (1):
      net/sched: act_api: deny mismatched skip_sw/skip_hw flags for actions created by classifiers

Wang Hai (2):
      net/sun3_82586: fix potential memory leak in sun3_82586_send_packet()
      be2net: fix potential memory leak in be_xmit()

Yuan Can (1):
      mlxsw: spectrum_router: fix xa_store() error checking

 .mailmap                                           |   5 +
 MAINTAINERS                                        |   2 +
 drivers/net/dsa/microchip/ksz_common.c             |  21 ++--
 drivers/net/dsa/mv88e6xxx/chip.h                   |   6 +-
 drivers/net/dsa/mv88e6xxx/port.c                   |   1 +
 drivers/net/dsa/mv88e6xxx/ptp.c                    | 108 ++++++++++++++-------
 drivers/net/ethernet/broadcom/bnxt/bnxt.c          |  22 +++--
 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c      |  70 +++++++------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.h      |  12 ++-
 drivers/net/ethernet/emulex/benet/be_main.c        |  10 +-
 drivers/net/ethernet/freescale/fman/mac.c          |  68 +++++++++----
 drivers/net/ethernet/freescale/fman/mac.h          |   6 +-
 drivers/net/ethernet/i825xx/sun3_82586.c           |   1 +
 drivers/net/ethernet/marvell/octeon_ep/octep_rx.c  |  82 +++++++++++-----
 .../net/ethernet/mellanox/mlxsw/spectrum_router.c  |   9 +-
 drivers/net/ethernet/realtek/r8169_main.c          |   4 +-
 drivers/net/hyperv/netvsc_drv.c                    |  30 ++++++
 drivers/net/phy/dp83822.c                          |   4 +-
 drivers/net/plip/plip.c                            |   2 +-
 drivers/net/pse-pd/pse_core.c                      |   4 +-
 drivers/net/usb/qmi_wwan.c                         |   1 +
 drivers/net/usb/usbnet.c                           |   3 +-
 drivers/net/virtio_net.c                           |   2 +-
 drivers/net/wwan/wwan_core.c                       |   2 +-
 include/linux/netdevice.h                          |  12 +++
 include/net/bluetooth/bluetooth.h                  |   1 +
 include/net/netns/xfrm.h                           |   1 -
 include/net/xfrm.h                                 |  28 +++---
 kernel/time/posix-clock.c                          |   6 +-
 net/bluetooth/af_bluetooth.c                       |  22 +++++
 net/bluetooth/hci_core.c                           |  24 +++--
 net/bluetooth/hci_sync.c                           |  12 ++-
 net/bluetooth/iso.c                                |  18 ++--
 net/bluetooth/sco.c                                |  18 ++--
 net/ipv4/xfrm4_policy.c                            |  40 ++++----
 net/ipv6/xfrm6_policy.c                            |  31 +++---
 net/netfilter/nf_bpf_link.c                        |   4 +
 net/netfilter/xt_NFLOG.c                           |   2 +-
 net/netfilter/xt_TRACE.c                           |   1 +
 net/netfilter/xt_mark.c                            |   2 +-
 net/sched/act_api.c                                |  23 ++++-
 net/sched/sch_generic.c                            |   8 +-
 net/sched/sch_taprio.c                             |  21 ++--
 net/xfrm/xfrm_device.c                             |  11 ++-
 net/xfrm/xfrm_policy.c                             |  53 +++++++---
 net/xfrm/xfrm_user.c                               |  10 +-
 46 files changed, 565 insertions(+), 258 deletions(-)

Re: [GIT PULL] Networking for v6.12-rc5

[Sasha Levin]

Sorry for the spam below, this is another attempt to solicit feedback to
the -next analysis tools that a few of us were working on.

Bigger changes since the last attempt:

   - Count calendar days rather than number of tags for the histogram.  
   - Make histogram more concise when possible (the below is *not* a good
     example of the new functionality).
   - Add more statistics to the report.

On Thu, Oct 24, 2024 at 04:01:01PM +0200, Paolo Abeni wrote:
>Hi Linus!
>
>Oddily this includes a fix for posix clock regression; in our previous PR
>we included a change there as a pre-requisite for networking one.
>Such fix proved to be buggy and requires the follow-up included here.
>Thomas suggested we should send it, given we sent the buggy patch.
>
>The following changes since commit 07d6bf634bc8f93caf8920c9d61df761645336e2:
>
>  Merge tag 'net-6.12-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2024-10-17 09:31:18 -0700)
>
>are available in the Git repository at:
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git net-6.12-rc5

Days in linux-next:
----------------------------------------
  0 | █████████████████████████████████████████████████ (14)
  1 | ███████ (2)
  2 | █████████████████████ (6)
  3 | ██████████████████████████████████████████ (12)
  4 |
  5 |
  6 | ███ (1)
  7 |
  8 | ███ (1)
  9 |
10 |
11 |
12 |
13 |
14+| ██████████████ (4)

Commits with 0 days in linux-next (14 of 40: 35.0%):
--------------------------------
3e65ede526cf4 net: dsa: mv88e6xxx: support 4000ps cycle counter period
7e3c18097a709 net: dsa: mv88e6xxx: read cycle counter period from hardware
67af86afff74c net: dsa: mv88e6xxx: group cycle counter coefficients
64761c980cbf7 net: usb: qmi_wwan: add Fibocom FG132 0x0112 composition
4c262801ea60c hv_netvsc: Fix VF namespace also in synthetic NIC NETDEV_REGISTER event
ee76eb24343bd net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x
246b435ad6685 Bluetooth: ISO: Fix UAF on iso_sock_timeout
1bf4470a3939c Bluetooth: SCO: Fix UAF on sco_sock_timeout
989fa5171f005 Bluetooth: hci_core: Disable works on hci_unregister_dev
6e62807c7fbb3 posix-clock: posix-clock: Fix unbalanced locking in pc_clock_settime()
10ce0db787004 r8169: avoid unsolicited interrupts
b22db8b8befe9 net: sched: use RCU read-side critical section in taprio_dump()
f504465970aeb net: sched: fix use-after-free in taprio_change()
34d35b4edbbe8 net/sched: act_api: deny mismatched skip_sw/skip_hw flags for actions created by classifiers

-- 
Thanks,
Sasha

Re: [GIT PULL] Networking for v6.12-rc5

[pr-tracker-bot]

The pull request you sent on Thu, 24 Oct 2024 16:01:01 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git net-6.12-rc5

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d44cd8226449114780a8554fd253c7e3d171a0a6

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] Networking for v6.12-rc5

[Michael Ellerman]

Sasha Levin <sashal@kernel.org> writes:
> Sorry for the spam below, this is another attempt to solicit feedback to
> the -next analysis tools that a few of us were working on.
>
> Bigger changes since the last attempt:
>
>    - Count calendar days rather than number of tags for the histogram.
    
I think this is a good change, but the presentation of the information
probably needs a bit of work.

Some of the commits below are in next-20241024, which was tagged less
than one day ago, but some are not. But they're all shown as "0 days",
which I think will confuse people.

I think you need to differentiate between 0 days in linux-next vs
*never* in linux-next. Otherwise folks are going to yell at you and say
"that commit was in linux-next!".

>    - Make histogram more concise when possible (the below is *not* a good
>      example of the new functionality).
>    - Add more statistics to the report.
>
> On Thu, Oct 24, 2024 at 04:01:01PM +0200, Paolo Abeni wrote:
>>Hi Linus!
>>
>>Oddily this includes a fix for posix clock regression; in our previous PR
>>we included a change there as a pre-requisite for networking one.
>>Such fix proved to be buggy and requires the follow-up included here.
>>Thomas suggested we should send it, given we sent the buggy patch.
>>
>>The following changes since commit 07d6bf634bc8f93caf8920c9d61df761645336e2:
>>
>>  Merge tag 'net-6.12-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2024-10-17 09:31:18 -0700)
>>
>>are available in the Git repository at:
>>
>>  git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git net-6.12-rc5
>
> Days in linux-next:
> ----------------------------------------
>   0 | █████████████████████████████████████████████████ (14)
>   1 | ███████ (2)
   
So I think here you need something like (numbers made up):

Days in linux-next:
----------------------------------------
   0 | ███████████████ (4)
 < 1 | █████████████████████████████████████████████████ (10)
   1 | ███████ (2)

To make it clear that some commits were not in linux-next at all,
whereas some were but for such a short time that they can hardly have
seen any testing. (Which still has some value, because at least we know
they didn't cause a merge conflict and passed at least some build
testing that sfr does during the linux-next merge).

>   2 | █████████████████████ (6)
>   3 | ██████████████████████████████████████████ (12)
>   4 |
>   5 |
>   6 | ███ (1)
>   7 |
>   8 | ███ (1)
>   9 |
> 10 |
> 11 |
> 12 |
> 13 |
> 14+| ██████████████ (4)
>
> Commits with 0 days in linux-next (14 of 40: 35.0%):
> --------------------------------
> 3e65ede526cf4 net: dsa: mv88e6xxx: support 4000ps cycle counter period
> 7e3c18097a709 net: dsa: mv88e6xxx: read cycle counter period from hardware
> 67af86afff74c net: dsa: mv88e6xxx: group cycle counter coefficients
> 64761c980cbf7 net: usb: qmi_wwan: add Fibocom FG132 0x0112 composition
> 4c262801ea60c hv_netvsc: Fix VF namespace also in synthetic NIC NETDEV_REGISTER event
> ee76eb24343bd net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x
> 246b435ad6685 Bluetooth: ISO: Fix UAF on iso_sock_timeout
> 1bf4470a3939c Bluetooth: SCO: Fix UAF on sco_sock_timeout
> 989fa5171f005 Bluetooth: hci_core: Disable works on hci_unregister_dev
 
The commits below here are in today's linux-next (next-20241024):

> 6e62807c7fbb3 posix-clock: posix-clock: Fix unbalanced locking in pc_clock_settime()
> 10ce0db787004 r8169: avoid unsolicited interrupts
> b22db8b8befe9 net: sched: use RCU read-side critical section in taprio_dump()
> f504465970aeb net: sched: fix use-after-free in taprio_change()
> 34d35b4edbbe8 net/sched: act_api: deny mismatched skip_sw/skip_hw flags for actions created by classifiers

The first question that comes to mind here is what's the diffstat for
these like.

There's a big difference if these are all tight few-line fixes to
individual drivers or sprawling hundred line changes that touch arch
code etc.

Listing the diffstat for all of them individually would be way too
spammy. Passing all the sha's to git show and using diffstat seems to
give a reasonable overview, eg:

$ git show -p 3e65ede526cf4 7e3c18097a709 67af86afff74c 64761c980cbf7 4c262801ea60c ee76eb24343bd 246b435ad6685 1bf4470a3939c 989fa5171f005 | diffstat -p1

 drivers/net/dsa/microchip/ksz_common.c |   21 +++++++++++----------
 drivers/net/dsa/mv88e6xxx/chip.h       |    8 +++-----
 drivers/net/dsa/mv88e6xxx/ptp.c        |  142 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
 drivers/net/hyperv/netvsc_drv.c        |   30 ++++++++++++++++++++++++++++++
 drivers/net/usb/qmi_wwan.c             |    1 +
 include/net/bluetooth/bluetooth.h      |    1 +
 net/bluetooth/af_bluetooth.c           |   22 ++++++++++++++++++++++
 net/bluetooth/hci_core.c               |   24 +++++++++++++++---------
 net/bluetooth/hci_sync.c               |   12 +++++++++---
 net/bluetooth/iso.c                    |   18 ++++++++++++------
 net/bluetooth/sco.c                    |   18 ++++++++++++------
 11 files changed, 208 insertions(+), 89 deletions(-)

I know the pull request has a diffstat, but they are significantly different.

Apologies for bike-shedding this so hard, it's just because I think it
would be a good addition to the development culture.

cheers

Re: [GIT PULL] Networking for v6.12-rc5

[patchwork-bot+netdevbpf]

Hello:

This pull request was applied to bpf/bpf.git (master)
by Linus Torvalds <torvalds@linux-foundation.org>:

On Thu, 24 Oct 2024 16:01:01 +0200 you wrote:
> Hi Linus!
> 
> Oddily this includes a fix for posix clock regression; in our previous PR
> we included a change there as a pre-requisite for networking one.
> Such fix proved to be buggy and requires the follow-up included here.
> Thomas suggested we should send it, given we sent the buggy patch.
> 
> [...]

Here is the summary with links:
  - [GIT,PULL] Networking for v6.12-rc5
    https://git.kernel.org/bpf/bpf/c/d44cd8226449

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [GIT PULL] Networking for v6.12-rc5

[Sasha Levin]

On Fri, Oct 25, 2024 at 12:44:54PM +1100, Michael Ellerman wrote:
>Sasha Levin <sashal@kernel.org> writes:
>> Sorry for the spam below, this is another attempt to solicit feedback to
>> the -next analysis tools that a few of us were working on.
>>
>> Bigger changes since the last attempt:
>>
>>    - Count calendar days rather than number of tags for the histogram.
>
>I think this is a good change, but the presentation of the information
>probably needs a bit of work.
>
>Some of the commits below are in next-20241024, which was tagged less
>than one day ago, but some are not. But they're all shown as "0 days",
>which I think will confuse people.
>
>I think you need to differentiate between 0 days in linux-next vs
>*never* in linux-next. Otherwise folks are going to yell at you and say
>"that commit was in linux-next!".
>
>>    - Make histogram more concise when possible (the below is *not* a good
>>      example of the new functionality).
>>    - Add more statistics to the report.
>>
>> On Thu, Oct 24, 2024 at 04:01:01PM +0200, Paolo Abeni wrote:
>>>Hi Linus!
>>>
>>>Oddily this includes a fix for posix clock regression; in our previous PR
>>>we included a change there as a pre-requisite for networking one.
>>>Such fix proved to be buggy and requires the follow-up included here.
>>>Thomas suggested we should send it, given we sent the buggy patch.
>>>
>>>The following changes since commit 07d6bf634bc8f93caf8920c9d61df761645336e2:
>>>
>>>  Merge tag 'net-6.12-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net (2024-10-17 09:31:18 -0700)
>>>
>>>are available in the Git repository at:
>>>
>>>  git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git net-6.12-rc5
>>
>> Days in linux-next:
>> ----------------------------------------
>>   0 | █████████████████████████████████████████████████ (14)
>>   1 | ███████ (2)
>
>So I think here you need something like (numbers made up):
>
>Days in linux-next:
>----------------------------------------
>   0 | ███████████████ (4)
> < 1 | █████████████████████████████████████████████████ (10)
>   1 | ███████ (2)
>
>To make it clear that some commits were not in linux-next at all,
>whereas some were but for such a short time that they can hardly have
>seen any testing. (Which still has some value, because at least we know
>they didn't cause a merge conflict and passed at least some build
>testing that sfr does during the linux-next merge).

Makes sense, added in https://git.kernel.org/pub/scm/linux/kernel/git/sashal/next-analysis.git/commit/?id=116b9550ccd6fb5e7f2ba9375af59392e03abb57

>>   2 | █████████████████████ (6)
>>   3 | ██████████████████████████████████████████ (12)
>>   4 |
>>   5 |
>>   6 | ███ (1)
>>   7 |
>>   8 | ███ (1)
>>   9 |
>> 10 |
>> 11 |
>> 12 |
>> 13 |
>> 14+| ██████████████ (4)
>>
>> Commits with 0 days in linux-next (14 of 40: 35.0%):
>> --------------------------------
>> 3e65ede526cf4 net: dsa: mv88e6xxx: support 4000ps cycle counter period
>> 7e3c18097a709 net: dsa: mv88e6xxx: read cycle counter period from hardware
>> 67af86afff74c net: dsa: mv88e6xxx: group cycle counter coefficients
>> 64761c980cbf7 net: usb: qmi_wwan: add Fibocom FG132 0x0112 composition
>> 4c262801ea60c hv_netvsc: Fix VF namespace also in synthetic NIC NETDEV_REGISTER event
>> ee76eb24343bd net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x
>> 246b435ad6685 Bluetooth: ISO: Fix UAF on iso_sock_timeout
>> 1bf4470a3939c Bluetooth: SCO: Fix UAF on sco_sock_timeout
>> 989fa5171f005 Bluetooth: hci_core: Disable works on hci_unregister_dev
>
>The commits below here are in today's linux-next (next-20241024):
>
>> 6e62807c7fbb3 posix-clock: posix-clock: Fix unbalanced locking in pc_clock_settime()
>> 10ce0db787004 r8169: avoid unsolicited interrupts
>> b22db8b8befe9 net: sched: use RCU read-side critical section in taprio_dump()
>> f504465970aeb net: sched: fix use-after-free in taprio_change()
>> 34d35b4edbbe8 net/sched: act_api: deny mismatched skip_sw/skip_hw flags for actions created by classifiers
>
>The first question that comes to mind here is what's the diffstat for
>these like.
>
>There's a big difference if these are all tight few-line fixes to
>individual drivers or sprawling hundred line changes that touch arch
>code etc.
>
>Listing the diffstat for all of them individually would be way too
>spammy. Passing all the sha's to git show and using diffstat seems to
>give a reasonable overview, eg:
>
>$ git show -p 3e65ede526cf4 7e3c18097a709 67af86afff74c 64761c980cbf7 4c262801ea60c ee76eb24343bd 246b435ad6685 1bf4470a3939c 989fa5171f005 | diffstat -p1
>
> drivers/net/dsa/microchip/ksz_common.c |   21 +++++++++++----------
> drivers/net/dsa/mv88e6xxx/chip.h       |    8 +++-----
> drivers/net/dsa/mv88e6xxx/ptp.c        |  142 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------
> drivers/net/hyperv/netvsc_drv.c        |   30 ++++++++++++++++++++++++++++++
> drivers/net/usb/qmi_wwan.c             |    1 +
> include/net/bluetooth/bluetooth.h      |    1 +
> net/bluetooth/af_bluetooth.c           |   22 ++++++++++++++++++++++
> net/bluetooth/hci_core.c               |   24 +++++++++++++++---------
> net/bluetooth/hci_sync.c               |   12 +++++++++---
> net/bluetooth/iso.c                    |   18 ++++++++++++------
> net/bluetooth/sco.c                    |   18 ++++++++++++------
> 11 files changed, 208 insertions(+), 89 deletions(-)
>
>I know the pull request has a diffstat, but they are significantly different.

I agree with needing diffstat, but I don't think we should just add them
all together. Instead, I've added diffstat on a per-commit basis to the
commits with 0 days. Something like:

Commits with 0 days in linux-next (5 of 26: 19.2%):
--------------------------------
a1b2c3d blah blah blah
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 25 ++++++++++++++-----------
  1 file changed, 14 insertions(+), 11 deletions(-)

e4f5g6h more blah
  security/keys/trusted.c          | 15 +++++++++------
  security/keys/trusted-keys.c     | 12 ++++++++----
  2 files changed, 17 insertions(+), 10 deletions(-)

This way it's easy to ignore one-liners, and look at bigger commits that
skipped -next.

>Apologies for bike-shedding this so hard, it's just because I think it
>would be a good addition to the development culture.

No worries, these are great improvements. Thanks!

-- 
Thanks,
Sasha

Re: [GIT PULL] Networking for v6.12-rc5

[Sasha Levin]

[snip]

I ran the current state of the scripts on the delta between Linus's
master and linus-next. It is pasted below.

The number of patches that haven't been in -next in this random sample
is indeed worrysome (and provides a good justification to the
(unrelated) linus-next effort).

As a reminder, the scripts are available at
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/next-analysis.git/
, and I'm happy to help with issues around them.

To avoid getting on everyone's nerves, I don't plan on bringing these up
again in the context of random PRs unless asked to do so by the relevant
maintainers/Linus.



Days in linux-next:
----------------------------------------
  0 | ██████████████████████████████████████████████████ (32)
<1 | ████ (3)
  1 | ████ (3)
  2 | ████████████ (8)
  3 | ███████████████ (10)
  4 | ███████████████ (10)
  5 | 
  6 | 
  7 | 
  8 | ███ (2)
  9 | ██████ (4)
10 | █ (1)
11 | ███████ (5)
12 | 
13 | 
14+| █████████████████ (11)

Commits with 0 days in linux-next (35 of 89: 39.3%):
--------------------------------
d34a5575e6d23 fuse: remove stray debug line
  fs/fuse/passthrough.c | 1 -
  1 file changed, 1 deletion(-)

cdc21021f0351 drm/xe: Don't restart parallel queues multiple times on GT reset
  drivers/gpu/drm/xe/xe_guc_submit.c | 14 ++++++++++++--
  1 file changed, 12 insertions(+), 2 deletions(-)

9c1813b325348 drm/xe/ufence: Prefetch ufence addr to catch bogus address
  drivers/gpu/drm/xe/xe_sync.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

69418db678567 drm/xe: Handle unreliable MMIO reads during forcewake
  drivers/gpu/drm/xe/xe_force_wake.c | 12 +++++++++---
  1 file changed, 9 insertions(+), 3 deletions(-)

22ef43c78647d drm/xe/guc/ct: Flush g2h worker in case of g2h response timeout
  drivers/gpu/drm/xe/xe_guc_ct.c | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)

c8fb95e7a5431 drm/xe: Enlarge the invalidation timeout from 150 to 500
  drivers/gpu/drm/xe/xe_device.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

d93df29bdab13 cpufreq: CPPC: fix perf_to_khz/khz_to_perf conversion exception
  drivers/acpi/cppc_acpi.c | 22 +++++++++++++++++-----
  1 file changed, 17 insertions(+), 5 deletions(-)

3d1c651272cf1 ACPI: PRM: Clean up guid type in struct prm_handler_info
  drivers/acpi/prmt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

8e59a2a5459fd ata: libata: Set DID_TIME_OUT for commands that actually timed out
  drivers/ata/libata-eh.c | 1 +
  1 file changed, 1 insertion(+)

7c210ca5a2d72 drm/amdgpu: handle default profile on on devices without fullscreen 3D
  drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 11 ++++++++++-
  1 file changed, 10 insertions(+), 1 deletion(-)

ba1959f71117b drm/amd/display: Disable PSR-SU on Parade 08-01 TCON too
  drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 ++
  1 file changed, 2 insertions(+)

108bc59fe8176 drm/amdgpu: fix random data corruption for sdma 7
  drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)

63feb35cd2655 drm/amd/display: temp w/a for DP Link Layer compliance
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 13 +++++++++++++
  1 file changed, 13 insertions(+)

23d16ede33a4d drm/amd/display: temp w/a for dGPU to enter idle optimizations
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

f67644b219d45 drm/amd/pm: update deep sleep status on smu v14.0.2/3
  drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

f888e3d34b864 drm/amd/pm: update overdrive function on smu v14.0.2/3
  drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

9515e74d756b6 drm/amd/pm: update the driver-fw interface file for smu v14.0.2/3
  drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu14_driver_if_v14_0.h | 132 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------
  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v14_0.h                     |   2 +-
  drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c             |  57 +++++++++++++-----------------------------
  3 files changed, 102 insertions(+), 89 deletions(-)

bf58f03931fdc drm/amd: Guard against bad data for ATIF ACPI method
  drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 15 ++++++++++++---
  1 file changed, 12 insertions(+), 3 deletions(-)

d719fecdc2d6d media: i2c: tc358743: export InfoFrames to debugfs
  drivers/media/i2c/tc358743.c | 36 +++++++++++++++++++++++++++++++++++-
  1 file changed, 35 insertions(+), 1 deletion(-)

be3aeece83e23 media: i2c: adv7842: export InfoFrames to debugfs
  drivers/media/i2c/adv7842.c | 120 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------
  1 file changed, 88 insertions(+), 32 deletions(-)

6703538b8b6f8 media: i2c: adv7604: export InfoFrames to debugfs
  drivers/media/i2c/adv7604.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------
  1 file changed, 70 insertions(+), 20 deletions(-)

b0644b12f2579 media: i2c: adv7511-v4l2: export InfoFrames to debugfs
  drivers/media/i2c/adv7511-v4l2.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------
  1 file changed, 74 insertions(+), 17 deletions(-)

155043e173660 media: v4l2-core: add v4l2_debugfs_if_alloc/free()
  drivers/media/v4l2-core/v4l2-dv-timings.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  include/media/v4l2-dv-timings.h           | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 115 insertions(+)

e24486d0c6992 media: v4l2-core: add v4l2_debugfs_root()
  drivers/media/v4l2-core/v4l2-dev.c | 14 ++++++++++++++
  include/media/v4l2-dev.h           | 15 +++++++++++++++
  2 files changed, 29 insertions(+)

3d882f3a391db media: vb2: use lock if wait_prepare/finish are NULL
  drivers/media/common/videobuf2/videobuf2-core.c | 13 ++++++++++---
  1 file changed, 10 insertions(+), 3 deletions(-)

aea26177c7175 media: vb2: vb2_core_queue_init(): sanity check lock and wait_prepare/finish
  drivers/media/common/videobuf2/videobuf2-core.c | 8 ++++++++
  1 file changed, 8 insertions(+)

22122f2094934 media: video-i2c: set lock before calling vb2_queue_init()
  drivers/media/i2c/video-i2c.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

b251fe7db1cde media: rcar_drif.c: set lock before calling vb2_queue_init()
  drivers/media/platform/renesas/rcar_drif.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

89795432ae06a media: airspy: set lock before calling vb2_queue_init()
  drivers/media/usb/airspy/airspy.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

734f583127067 media: hackrf: set lock before calling vb2_queue_init()
  drivers/media/usb/hackrf/hackrf.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

cc123e96b0c44 media: msi2500: set lock before calling vb2_queue_init()
  drivers/media/usb/msi2500/msi2500.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

8d7d72a400c43 media: pwc: set lock before calling vb2_queue_init()
  drivers/media/usb/pwc/pwc-if.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

38b1ea00360b9 media: venus: add missing wait_prepare/finish ops
  drivers/media/platform/qcom/venus/vdec.c | 2 ++
  drivers/media/platform/qcom/venus/venc.c | 2 ++
  2 files changed, 4 insertions(+)

fc3c6515678bf media: pisp_be: add missing wait_prepare/finish ops
  drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 2 ++
  1 file changed, 2 insertions(+)

8ebcb4796639e media: omap3isp: add missing wait_prepare/finish ops
  drivers/media/platform/ti/omap3isp/ispvideo.c | 18 ++++++++++++++++++
  1 file changed, 18 insertions(+)


Commits not found on lore.kernel.org/all (4 of 89: 4%):
----------------------------------------
d34a5575e6d23 fuse: remove stray debug line
e3ea2757c312e ALSA: hda/realtek: Update default depop procedure
f888e3d34b864 drm/amd/pm: update overdrive function on smu v14.0.2/3
155043e173660 media: v4l2-core: add v4l2_debugfs_if_alloc/free()

-- 
Thanks,
Sasha

Re: [GIT PULL] Networking for v6.12-rc5

[Christoph Hellwig]

On Thu, Oct 24, 2024 at 10:28:03AM -0400, Sasha Levin wrote:
> Days in linux-next:
> ----------------------------------------
>  0 | █████████████████████████████████████████████████ (14)
>  1 | ███████ (2)
>  2 | █████████████████████ (6)
>  3 | ██████████████████████████████████████████ (12)
>  4 |

Can you replace the full block filling "characters" with a say "+"
characters as in diff statistics to make this hurt the eyes a little
less?

Re: [GIT PULL] Networking for v6.12-rc5

[Sasha Levin]

On Mon, Oct 28, 2024 at 05:12:56AM -0700, Christoph Hellwig wrote:
>On Thu, Oct 24, 2024 at 10:28:03AM -0400, Sasha Levin wrote:
>> Days in linux-next:
>> ----------------------------------------
>>  0 | █████████████████████████████████████████████████ (14)
>>  1 | ███████ (2)
>>  2 | █████████████████████ (6)
>>  3 | ██████████████████████████████████████████ (12)
>>  4 |
>
>Can you replace the full block filling "characters" with a say "+"
>characters as in diff statistics to make this hurt the eyes a little
>less?

Yup!

-- 
Thanks,
Sasha