From: Stanislav Fomichev <stfomichev@gmail.com>
To: Joe Damato <jdamato@fastly.com>,
Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch,
shuah@kernel.org, horms@kernel.org, almasrymina@google.com,
willemb@google.com, petrm@nvidia.com
Subject: Re: [PATCH net-next v8 00/12] selftests: ncdevmem: Add ncdevmem to ksft
Date: Thu, 7 Nov 2024 17:18:20 -0800 [thread overview]
Message-ID: <Zy1m3IkTR6GKObKE@mini-arch> (raw)
In-Reply-To: <Zy0J1_3P76EACrBG@LQ3V64L9R2>
On 11/07, Joe Damato wrote:
> On Thu, Nov 07, 2024 at 10:11:59AM -0800, Stanislav Fomichev wrote:
> > The goal of the series is to simplify and make it possible to use
> > ncdevmem in an automated way from the ksft python wrapper.
> >
> > ncdevmem is slowly mutated into a state where it uses stdout
> > to print the payload and the python wrapper is added to
> > make sure the arrived payload matches the expected one.
> >
> > v8:
> > - move error() calls into enable_reuseaddr() (Joe)
> > - bail out when number of queues is 1 (Joe)
>
> Thanks for all the work on the refactor; sorry for the nit-picking
> on the queue counts. I just thought of it because in my test for
> busy poll stuff, netdevsim uses 1 queue.
>
> Having tests like this factored nicely really helps when people
> (like me) go to try to write a test for the first time and have a
> good example like this to follow :)
No worries, thanks for taking the time to review! nit-picks are fine
as wells since they are usually the easiest ones to address :-D
next prev parent reply other threads:[~2024-11-08 1:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 18:11 [PATCH net-next v8 00/12] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 02/12] selftests: ncdevmem: Separate out dmabuf provider Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 03/12] selftests: ncdevmem: Unify error handling Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 04/12] selftests: ncdevmem: Make client_ip optional Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 05/12] selftests: ncdevmem: Remove default arguments Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 06/12] selftests: ncdevmem: Switch to AF_INET6 Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 07/12] selftests: ncdevmem: Properly reset flow steering Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 08/12] selftests: ncdevmem: Use YNL to enable TCP header split Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 09/12] selftests: ncdevmem: Remove hard-coded queue numbers Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw Stanislav Fomichev
2024-11-07 18:12 ` [PATCH net-next v8 12/12] selftests: ncdevmem: Add automated test Stanislav Fomichev
2024-11-07 18:37 ` Joe Damato
2024-11-07 18:41 ` [PATCH net-next v8 00/12] selftests: ncdevmem: Add ncdevmem to ksft Joe Damato
2024-11-08 1:18 ` Stanislav Fomichev [this message]
2024-11-12 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy1m3IkTR6GKObKE@mini-arch \
--to=stfomichev@gmail.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).