From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Lei Wei <quic_leiwei@quicinc.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_kkumarcs@quicinc.com,
quic_suruchia@quicinc.com, quic_pavir@quicinc.com,
quic_linchen@quicinc.com, quic_luoj@quicinc.com,
srinivas.kandagatla@linaro.org, bartosz.golaszewski@linaro.org,
vsmuthu@qti.qualcomm.com, john@phrozen.org
Subject: Re: [PATCH net-next 3/5] net: pcs: qcom-ipq: Add PCS create and phylink operations for IPQ9574
Date: Fri, 8 Nov 2024 11:37:02 +0000 [thread overview]
Message-ID: <Zy333s8o77qE5F_-@shell.armlinux.org.uk> (raw)
In-Reply-To: <9b7def00-e900-4c5e-ba95-671bd1ef9240@quicinc.com>
On Fri, Nov 08, 2024 at 07:31:31PM +0800, Lei Wei wrote:
> On 11/6/2024 11:43 AM, Andrew Lunn wrote:
> > On Wed, Nov 06, 2024 at 11:16:37AM +0800, Lei Wei wrote:
> > > On 11/1/2024 9:21 PM, Andrew Lunn wrote:
> > > > How does Qualcomm SGMII AN mode differ from Cisco SGMII AN mode?
> > >
> > > Qualcomm SGMII AN mode extends Cisco SGMII spec Revision 1.8 by adding pause
> > > bit support in the SGMII word format. It re-uses two of the reserved bits
> > > 1..9 for this purpose. The PCS supports both Qualcomm SGMII AN and Cisco
> > > SGMII AN modes.
> >
> > Is Qualcomm SGMII AN actually needed? I assume it only works against a
> > Qualcomm PHY? What interoperability testing have you do against
> > non-Qualcomm PHYs?
>
> I agree that using Cisco SGMII AN mode as default is more appropriate,
> since is more commonly used with PHYs. I will make this change.
>
> Qualcomm SGMII AN is an extension of top of Cisco SGMII AN (only
> pause bits difference). So it is expected to be compatible with
> non-Qualcomm PHYs which use Cisco SGMII AN.
I believe Marvell have similar extensions.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-11-08 11:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 10:32 [PATCH net-next 0/5] Add PCS support for Qualcomm IPQ9574 SoC Lei Wei
2024-11-01 10:32 ` [PATCH net-next 1/5] dt-bindings: net: pcs: Add Ethernet PCS " Lei Wei
2024-11-02 13:34 ` Krzysztof Kozlowski
2024-11-04 11:01 ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 2/5] net: pcs: Add PCS driver " Lei Wei
2024-11-01 13:00 ` Andrew Lunn
2024-11-04 11:14 ` Lei Wei
2024-11-04 13:43 ` Andrew Lunn
2024-11-07 12:12 ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 3/5] net: pcs: qcom-ipq: Add PCS create and phylink operations for IPQ9574 Lei Wei
2024-11-01 13:21 ` Andrew Lunn
2024-11-01 16:31 ` Jakub Kicinski
2024-11-06 3:16 ` Lei Wei
2024-11-06 3:43 ` Andrew Lunn
2024-11-08 11:31 ` Lei Wei
2024-11-08 11:37 ` Russell King (Oracle) [this message]
2024-11-08 13:24 ` Andrew Lunn
2024-11-12 12:48 ` Lei Wei
2024-11-07 19:02 ` Russell King (Oracle)
2024-11-08 12:03 ` Lei Wei
2024-11-01 10:32 ` [PATCH net-next 4/5] net: pcs: qcom-ipq: Add USXGMII interface mode " Lei Wei
2024-11-01 10:32 ` [PATCH net-next 5/5] MAINTAINERS: Add maintainer for Qualcomm IPQ PCS driver Lei Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy333s8o77qE5F_-@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vsmuthu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).