From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA6CE4779F for ; Sat, 9 Nov 2024 05:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731128760; cv=none; b=p873nJcUPDIm/5z6QSuyaC3TJGmpuk9rUqvmTbXJES7eb103guUb3qkQiY3R3Y7WjVJm3ze9MNV2FU4AWWl/mvVXkbuXa8znVb5O9mQa8ZYACKn+1j4SgRtG69diFvYeZ70IqRAnV7p+E8wkRfn4iAjIwHwK0M3G6M1j5kb5tbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731128760; c=relaxed/simple; bh=5d2luErJ4t2O8IYA7jlZfwk/vLJ8um8i6qUXK3HLdLE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LDcEYBs1iQCjvImqPkixBHWoA2u4o1Xsbg8iWkq+Qf3YwpNv+E45Wi7G7AVdSnkJwLXSmCrwao3nffT3NG+V/xRttFDBvtAJOiCqtJksD+m3BccNE3r6NLefYogn9dGOL60N7OJTzs69QkuRhXVbT8OEMeNEyY/uopUsDVfpO/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=AgCVibdr; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="AgCVibdr" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-720d5ada03cso2890376b3a.1 for ; Fri, 08 Nov 2024 21:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1731128758; x=1731733558; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ZkWm6lu8Vf7YjtBv89buVybDqSSTCm0miO4h7F33T64=; b=AgCVibdrXkjNyR4XcC7vnNdJMEanD6/ewK5+Z/6d89atu2d8zHaGLAwqw9OVH/Qvlc 4EbDNGuHIUE98qu0GSnuxfy719A7VgmHEp61CBT5zc+DX5ipLy173eT4sX5M54XMyWnR pFiX0maHdMk7wqFunMhfkz5FuKrWW+rJv4fdo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731128758; x=1731733558; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZkWm6lu8Vf7YjtBv89buVybDqSSTCm0miO4h7F33T64=; b=tcLPBwQ/DukPt711M/Ulzaybr1MY7/NgoDkYv6053e3zmzupn/Fr+U+tbO+wMiphAb vaIdojxUNIn5FMGokE+JXKE61g3cpB89OTo/eT+CTXm7lSky6kZ4JMnyVs9FzBvzzcs2 oELdV6tZuFQPsWYmk93EszrVRHa37l0HYXzdnPoPdEH1KHJv6Zvg0bSvVuhp2f6ypIaA bCS4CtQXOGIlfKwxiYmazSsmI/WjTyfDKUYakOA3jvmcMVdpTKhgeZT/3s4si8UZ94JP S22nq8hdN43vH4dSNyFrEXwOERcmELRnUe4C5XWKqKh+EggI/wIcSsP/d9OaDA4FTxGd uULw== X-Gm-Message-State: AOJu0Yw5oFE6NIN5WiaO4e9OXYTgoC5iNS/stvuwZOOsdeqdlo8L1kQo Q6rjLFC0JoiBQlnfGVlVg+NY55NyY4ej8DhaKhJfyzSRK1IZgdFhlEgIWry5HqI= X-Google-Smtp-Source: AGHT+IFWvbmK3ZUE2ROqqMys6VCbYpSt8HcccaDD5Sd5IJ2vW3JieKKtY77lB/QC93xpM9tDHaRh3g== X-Received: by 2002:a17:903:191:b0:20c:ecd8:d0af with SMTP id d9443c01a7336-211834e00cemr65937005ad.9.1731128758087; Fri, 08 Nov 2024 21:05:58 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177dc835fsm39402525ad.41.2024.11.08.21.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2024 21:05:57 -0800 (PST) Date: Fri, 8 Nov 2024 21:05:54 -0800 From: Joe Damato To: Willem de Bruijn Cc: netdev@vger.kernel.org, corbet@lwn.net, hdanton@sina.com, bagasdotme@gmail.com, pabeni@redhat.com, namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, skhawaja@google.com, kuba@kernel.org, Martin Karsten , "David S. Miller" , Simon Horman , Shuah Khan , open list , "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH net-next v8 5/6] selftests: net: Add busy_poll_test Message-ID: Mail-Followup-To: Joe Damato , Willem de Bruijn , netdev@vger.kernel.org, corbet@lwn.net, hdanton@sina.com, bagasdotme@gmail.com, pabeni@redhat.com, namangulati@google.com, edumazet@google.com, amritha.nambiar@intel.com, sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net, m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org, willy@infradead.org, skhawaja@google.com, kuba@kernel.org, Martin Karsten , "David S. Miller" , Simon Horman , Shuah Khan , open list , "open list:KERNEL SELFTEST FRAMEWORK" References: <20241108045337.292905-1-jdamato@fastly.com> <20241108045337.292905-6-jdamato@fastly.com> <672e26ec429be_2a4cd22944c@willemb.c.googlers.com.notmuch> <672e4ea4e979a_2bc2f629490@willemb.c.googlers.com.notmuch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <672e4ea4e979a_2bc2f629490@willemb.c.googlers.com.notmuch> On Fri, Nov 08, 2024 at 12:47:16PM -0500, Willem de Bruijn wrote: > Joe Damato wrote: > > On Fri, Nov 08, 2024 at 09:57:48AM -0500, Willem de Bruijn wrote: > > > Joe Damato wrote: [...] > > > > > > Nice test. > > > > > > Busy polling does not affect data integrity. Is the goal of this test > > > mainly to get coverage, maybe observe if the process would stall > > > indefinitely? > > > > Just to get coverage and make sure data makes it from point A to > > point B intact despite suspend being enabled. > > > > The last paragraph of the commit message highlights that netdevsim > > functionality is limited, so the test uses what is available. It can > > be extended in the future, when netdevsim supports more > > functionality. > > > > Paolo wanted a test and this is the best test we can provide given > > the limitations of the testing environment. > > > > > > netdevsim was chosen instead of veth due to netdevsim's support for > > > > netdev-genl. > > > > > > > > For now, this test uses the functionality that netdevsim provides. In the > > > > future, perhaps netdevsim can be extended to emulate device IRQs to more > > > > thoroughly test all pre-existing kernel options (like defer_hard_irqs) > > > > and suspend. > > > > [...] > > > > The rest of the feedback below seems pretty minor; I don't think > > it's worth spinning a v9 and re-sending just for this. > > > > If anything this can be handled with a clean up commit in the > > future. > > FWIW no objections from me. > > > Jakub: please let me know if you prefer to see a v9 for this? Since we passed the 24hr mark and the series hasn't been merged yet, I've sent a v9 just now that addresses the feedback you provided.