From: Joe Damato <jdamato@fastly.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, namangulati@google.com,
edumazet@google.com, amritha.nambiar@intel.com,
sridhar.samudrala@intel.com, sdf@fomichev.me, peter@typeblog.net,
m2shafiei@uwaterloo.ca, bjorn@rivosinc.com, hch@infradead.org,
willy@infradead.org, willemdebruijn.kernel@gmail.com,
skhawaja@google.com, kuba@kernel.org,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"open list:BPF [MISC] :Keyword:(?:b|_)bpf(?:b|_)"
<bpf@vger.kernel.org>, Christian Brauner <brauner@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Donald Hunter <donald.hunter@gmail.com>, Jan Kara <jack@suse.cz>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Johannes Berg <johannes.berg@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:FILESYSTEMS (VFS and infrastructure)"
<linux-fsdevel@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Martin Karsten <mkarsten@uwaterloo.ca>,
Mina Almasry <almasrymina@google.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH net-next v2 0/6] Suspend IRQs during application busy periods
Date: Tue, 29 Oct 2024 10:53:41 -0700 [thread overview]
Message-ID: <ZyEhJXCrZgBLMJgB@LQ3V64L9R2> (raw)
In-Reply-To: <57a0e1e7-1079-4055-8072-d9105b70103f@redhat.com>
On Tue, Oct 29, 2024 at 11:25:18AM +0100, Paolo Abeni wrote:
> On 10/21/24 03:52, Joe Damato wrote:
[...]
>
> The changes makes sense to me, and I could not find any obvious issue in
> the patches.
>
> I think this deserve some - even basic - self-tests coverage. Note that
> you can enable GRO on veth devices to make NAPI instances avail there.
>
> Possibly you could opt for a drivers/net defaulting to veth usage and
> allowing the user to select real H/W via env variables.
Sorry, Paolo, but I took a cursory look at veth and I need to object
more strongly to your feedback here.
My understanding (which could be incorrect) is that neither veth nor
netdevsim use IRQs.
The whole purpose of this series is to block IRQs while data is
being busy polled to increase efficiency. That's in the cover
letter.
If neither of the drivers we'd use to simulate this in selftest use
IRQs, how could we build a selftest which ensures IRQs are correctly
suspended during busy periods without first making considerable
changes to either (or both?) drivers?
Respectfully: I don't think it's appropriate to block this series on
that much additional work.
Please reconsider and let me know how to proceed.
prev parent reply other threads:[~2024-10-29 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 1:52 [PATCH net-next v2 0/6] Suspend IRQs during application busy periods Joe Damato
2024-10-21 1:52 ` [PATCH net-next v2 1/6] net: Add napi_struct parameter irq_suspend_timeout Joe Damato
2024-10-21 1:52 ` [PATCH net-next v2 2/6] net: Suspend softirq when prefer_busy_poll is set Joe Damato
2024-10-21 1:52 ` [PATCH net-next v2 3/6] net: Add control functions for irq suspension Joe Damato
2024-10-21 1:52 ` [PATCH net-next v2 4/6] eventpoll: Trigger napi_busy_loop, if prefer_busy_poll is set Joe Damato
2024-10-21 1:53 ` [PATCH net-next v2 5/6] eventpoll: Control irq suspension for prefer_busy_poll Joe Damato
2024-10-21 1:53 ` [PATCH net-next v2 6/6] docs: networking: Describe irq suspension Joe Damato
2024-10-21 10:49 ` Bagas Sanjaya
2024-10-21 16:33 ` Joe Damato
2024-10-25 1:03 ` Bagas Sanjaya
2024-10-24 23:05 ` [PATCH net-next v2 0/6] Suspend IRQs during application busy periods Stanislav Fomichev
2024-10-29 10:25 ` Paolo Abeni
2024-10-29 15:03 ` Joe Damato
2024-10-29 17:53 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyEhJXCrZgBLMJgB@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=amritha.nambiar@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bjorn@rivosinc.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jiri@resnulli.us \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=m2shafiei@uwaterloo.ca \
--cc=mkarsten@uwaterloo.ca \
--cc=namangulati@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter@typeblog.net \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willemdebruijn.kernel@gmail.com \
--cc=willy@infradead.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).