From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch,
shuah@kernel.org, almasrymina@google.com, willemb@google.com,
petrm@nvidia.com
Subject: Re: [PATCH net-next v5 03/12] selftests: ncdevmem: Unify error handling
Date: Tue, 29 Oct 2024 17:15:06 -0700 [thread overview]
Message-ID: <ZyF6iggvCbr32TOv@mini-arch> (raw)
In-Reply-To: <20241029170129.75e29323@kernel.org>
On 10/29, Jakub Kicinski wrote:
> On Wed, 23 Oct 2024 08:43:53 -0700 Stanislav Fomichev wrote:
> > ret = inet_pton(server_sin.sin_family, server_ip, &server_sin.sin_addr);
> > - if (socket < 0)
> > - error(79, 0, "%s: [FAIL, create socket]\n", TEST_PREFIX);
> > + if (ret < 0)
> > + error(1, pton, "%s: [FAIL, create socket]\n", TEST_PREFIX);
>
> Looks like sched_ext broke our build_tools check, I think I pushed a
> fix, but I also see here:
>
> ncdevmem.c: In function ‘do_server’:
> ncdevmem.c:343:26: error: ‘pton’ undeclared (first use in this function)
> 343 | error(1, pton, "%s: [FAIL, create socket]\n", TEST_PREFIX);
> | ^~~~
> --
> pw-bot: cr
Oh, thanks, will double check. This looks silly.
next prev parent reply other threads:[~2024-10-30 0:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 15:43 [PATCH net-next v5 00/12] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 02/12] selftests: ncdevmem: Separate out dmabuf provider Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 03/12] selftests: ncdevmem: Unify error handling Stanislav Fomichev
2024-10-30 0:01 ` Jakub Kicinski
2024-10-30 0:15 ` Stanislav Fomichev [this message]
2024-10-23 15:43 ` [PATCH net-next v5 04/12] selftests: ncdevmem: Make client_ip optional Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 05/12] selftests: ncdevmem: Remove default arguments Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 06/12] selftests: ncdevmem: Switch to AF_INET6 Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 07/12] selftests: ncdevmem: Properly reset flow steering Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 08/12] selftests: ncdevmem: Use YNL to enable TCP header split Stanislav Fomichev
2024-10-23 15:43 ` [PATCH net-next v5 09/12] selftests: ncdevmem: Remove hard-coded queue numbers Stanislav Fomichev
2024-10-23 15:44 ` [PATCH net-next v5 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided Stanislav Fomichev
2024-10-23 15:44 ` [PATCH net-next v5 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw Stanislav Fomichev
2024-10-23 15:44 ` [PATCH net-next v5 12/12] selftests: ncdevmem: Add automated test Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyF6iggvCbr32TOv@mini-arch \
--to=stfomichev@gmail.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).