Of ena auto_polling

Of ena auto_polling

[Dr. David Alan Gilbert]

Hi,
  I noticed that commit:
commit a4e262cde3cda4491ce666e7c5270954c4d926b9
Author: Sameeh Jubran <sameehj@amazon.com>
Date:   Mon Jun 3 17:43:25 2019 +0300

    net: ena: allow automatic fallback to polling mode

added a 'ena_com_set_admin_auto_polling_mode()' that's unused.
Is that the intention?
Because that then makes me wonder how
admin_queue->auto_polling
gets set, and then if the whole chunk is unused?

Thanks,

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

RE: Of ena auto_polling

[Arinzon, David]

> Hi,
>   I noticed that commit:
> commit a4e262cde3cda4491ce666e7c5270954c4d926b9
> Author: Sameeh Jubran <sameehj@amazon.com>
> Date:   Mon Jun 3 17:43:25 2019 +0300
> 
>     net: ena: allow automatic fallback to polling mode
> 
> added a 'ena_com_set_admin_auto_polling_mode()' that's unused.
> Is that the intention?
> Because that then makes me wonder how
> admin_queue->auto_polling
> gets set, and then if the whole chunk is unused?
> 
> Thanks,
> 
> Dave
> --
>  -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org
> |_______/

Hi Dave,
The auto polling mode was written as a fallback in case there are issues with interrupts,
it is currently not used by the ENA Linux driver, from Linux's perspective, it can be removed.

Re: Of ena auto_polling

[Dr. David Alan Gilbert]

* Arinzon, David (darinzon@amazon.com) wrote:
> > Hi,
> >   I noticed that commit:
> > commit a4e262cde3cda4491ce666e7c5270954c4d926b9
> > Author: Sameeh Jubran <sameehj@amazon.com>
> > Date:   Mon Jun 3 17:43:25 2019 +0300
> > 
> >     net: ena: allow automatic fallback to polling mode
> > 
> > added a 'ena_com_set_admin_auto_polling_mode()' that's unused.
> > Is that the intention?
> > Because that then makes me wonder how
> > admin_queue->auto_polling
> > gets set, and then if the whole chunk is unused?
> > 
> > Thanks,
> > 
> > Dave
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org
> > |_______/
> 
> Hi Dave,
> The auto polling mode was written as a fallback in case there are issues with interrupts,
> it is currently not used by the ENA Linux driver, from Linux's perspective, it can be removed.

Thanks for the reply,
I've just posted what I think is a suitable revert of it then,
see message 20241103194149.293456-1-linux@treblig.org.
I've build tested it only, so please give it a good check and shake out!

Thanks again for the reply, and the ack on the other patch.

Dave
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/