From: Ido Schimmel <idosch@nvidia.com>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
donald.hunter@redhat.com, Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule management
Date: Tue, 5 Nov 2024 16:35:29 +0200 [thread overview]
Message-ID: <ZyotMdGb23YbCBiK@shredder> (raw)
In-Reply-To: <20241105122831.85882-3-donald.hunter@gmail.com>
On Tue, Nov 05, 2024 at 12:28:31PM +0000, Donald Hunter wrote:
> Add a YNL spec for FIB rules:
>
> ./tools/net/ynl/cli.py \
> --spec Documentation/netlink/specs/rt_rule.yaml \
> --dump getrule --json '{"family": 2}'
>
> [{'action': 'to-tbl',
> 'dst-len': 0,
> 'family': 2,
> 'flags': 0,
> 'protocol': 2,
> 'src-len': 0,
> 'suppress-prefixlen': '0xffffffff',
> 'table': 255,
> 'tos': 0},
> ... ]
>
> Acked-by: Stanislav Fomichev <sdf@fomichev.me>
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
One question below (didn't notice it before)
[...]
> + -
> + name: getrule
> + doc: Dump all FIB rules
> + attribute-set: fib-rule-attrs
> + dump:
> + request:
> + value: 34
> + attributes:
> + - nsid
What is the significance of 'nsid' here?
> + reply:
> + value: 32
> + attributes: *fib-rule-all
next prev parent reply other threads:[~2024-11-05 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 12:28 [PATCH net-next v2 0/2] netlink: specs: Add neigh and rule YNL specs Donald Hunter
2024-11-05 12:28 ` [PATCH net-next v2 1/2] netlink: specs: Add a spec for neighbor tables in rtnetlink Donald Hunter
2024-11-05 12:28 ` [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule management Donald Hunter
2024-11-05 14:35 ` Ido Schimmel [this message]
2024-11-05 15:28 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyotMdGb23YbCBiK@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).