From: Joe Damato <jdamato@fastly.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
En-Wei Wu <en-wei.wu@canonical.com>
Subject: Re: [PATCH net-next 1/7] net: skb_reset_mac_len() must check if mac_header was set
Date: Tue, 5 Nov 2024 09:56:40 -0800 [thread overview]
Message-ID: <ZypcWB421XqVaiYS@LQ3V64L9R2> (raw)
In-Reply-To: <20241105174403.850330-2-edumazet@google.com>
On Tue, Nov 05, 2024 at 05:43:57PM +0000, Eric Dumazet wrote:
> Recent discussions show that skb_reset_mac_len() should be more careful.
>
> We expect the MAC header being set.
>
> If not, clear skb->mac_len and fire a warning for CONFIG_DEBUG_NET=y builds.
>
> If after investigations we find that not having a MAC header was okay,
> we can remove the warning.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Link: https://lore.kernel.org/netdev/CANn89iJZGH+yEfJxfPWa3Hm7jxb-aeY2Up4HufmLMnVuQXt38A@mail.gmail.com/T/
> Cc: En-Wei Wu <en-wei.wu@canonical.com>
> ---
> include/linux/skbuff.h | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2024-11-05 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 17:43 [PATCH net-next 0/7] net: add debug checks to skb_reset_xxx_header() Eric Dumazet
2024-11-05 17:43 ` [PATCH net-next 1/7] net: skb_reset_mac_len() must check if mac_header was set Eric Dumazet
2024-11-05 17:56 ` Joe Damato [this message]
2024-11-05 17:43 ` [PATCH net-next 2/7] net: add debug check in skb_reset_inner_transport_header() Eric Dumazet
2024-11-05 17:57 ` Joe Damato
2024-11-05 17:43 ` [PATCH net-next 3/7] net: add debug check in skb_reset_inner_network_header() Eric Dumazet
2024-11-05 17:57 ` Joe Damato
2024-11-05 17:44 ` [PATCH net-next 4/7] net: add debug check in skb_reset_inner_mac_header() Eric Dumazet
2024-11-05 17:58 ` Joe Damato
2024-11-05 17:44 ` [PATCH net-next 5/7] net: add debug check in skb_reset_transport_header() Eric Dumazet
2024-11-05 17:58 ` Joe Damato
2024-11-05 17:44 ` [PATCH net-next 6/7] net: add debug check in skb_reset_network_header() Eric Dumazet
2024-11-05 17:58 ` Joe Damato
2024-11-05 17:44 ` [PATCH net-next 7/7] net: add debug check in skb_reset_mac_header() Eric Dumazet
2024-11-05 17:59 ` Joe Damato
2024-11-06 9:52 ` [PATCH net-next 0/7] net: add debug checks to skb_reset_xxx_header() Xuan Zhuo
2024-11-07 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZypcWB421XqVaiYS@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=en-wei.wu@canonical.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).