[PATCH net-next] ipv4: Prepare ip_route_output() to future .flowi4_tos conversion.

[PATCH net-next] ipv4: Prepare ip_route_output() to future .flowi4_tos conversion.

[Guillaume Nault]

Convert the "tos" parameter of ip_route_output() to dscp_t. This way
we'll have a dscp_t value directly available when .flowi4_tos will
eventually be converted to dscp_t.

All ip_route_output() callers but one set this "tos" parameter to 0 and
therefore don't need to be adapted to the new prototype.

Only br_nf_pre_routing_finish() needs conversion. It can just use
ip4h_dscp() to get the DSCP field from the IPv4 header.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
---
 include/net/route.h             | 6 +++---
 net/bridge/br_netfilter_hooks.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/net/route.h b/include/net/route.h
index 586e59f7ed8a..0a690adfdff5 100644
--- a/include/net/route.h
+++ b/include/net/route.h
@@ -156,12 +156,12 @@ static inline struct rtable *ip_route_output_key(struct net *net, struct flowi4
  * structure is only partially set, it may bypass some fib-rules.
  */
 static inline struct rtable *ip_route_output(struct net *net, __be32 daddr,
-					     __be32 saddr, u8 tos, int oif,
-					     __u8 scope)
+					     __be32 saddr, dscp_t dscp,
+					     int oif, __u8 scope)
 {
 	struct flowi4 fl4 = {
 		.flowi4_oif = oif,
-		.flowi4_tos = tos,
+		.flowi4_tos = inet_dscp_to_dsfield(dscp),
 		.flowi4_scope = scope,
 		.daddr = daddr,
 		.saddr = saddr,
diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c
index 17a5f5923d61..7f2f40cef5fe 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -406,7 +406,7 @@ static int br_nf_pre_routing_finish(struct net *net, struct sock *sk, struct sk_
 				goto free_skb;
 
 			rt = ip_route_output(net, iph->daddr, 0,
-					     iph->tos & INET_DSCP_MASK, 0,
+					     ip4h_dscp(iph), 0,
 					     RT_SCOPE_UNIVERSE);
 			if (!IS_ERR(rt)) {
 				/* - Bridged-and-DNAT'ed traffic doesn't
-- 
2.39.2

Re: [PATCH net-next] ipv4: Prepare ip_route_output() to future .flowi4_tos conversion.

[Ido Schimmel]

On Wed, Nov 06, 2024 at 10:37:32PM +0100, Guillaume Nault wrote:
> Convert the "tos" parameter of ip_route_output() to dscp_t. This way
> we'll have a dscp_t value directly available when .flowi4_tos will
> eventually be converted to dscp_t.
> 
> All ip_route_output() callers but one set this "tos" parameter to 0 and
> therefore don't need to be adapted to the new prototype.
> 
> Only br_nf_pre_routing_finish() needs conversion. It can just use
> ip4h_dscp() to get the DSCP field from the IPv4 header.
> 
> Signed-off-by: Guillaume Nault <gnault@redhat.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Re: [PATCH net-next] ipv4: Prepare ip_route_output() to future .flowi4_tos conversion.

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 6 Nov 2024 22:37:32 +0100 you wrote:
> Convert the "tos" parameter of ip_route_output() to dscp_t. This way
> we'll have a dscp_t value directly available when .flowi4_tos will
> eventually be converted to dscp_t.
> 
> All ip_route_output() callers but one set this "tos" parameter to 0 and
> therefore don't need to be adapted to the new prototype.
> 
> [...]

Here is the summary with links:
  - [net-next] ipv4: Prepare ip_route_output() to future .flowi4_tos conversion.
    https://git.kernel.org/netdev/net-next/c/48171c65f611

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html