From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Herve Codina" <herve.codina@bootlin.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next 2/7] net: freescale: ucc_geth: split adjust_link for phylink conversion
Date: Thu, 7 Nov 2024 17:51:05 +0000 [thread overview]
Message-ID: <Zyz-CcO1inN06mtm@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241107170255.1058124-3-maxime.chevallier@bootlin.com>
On Thu, Nov 07, 2024 at 06:02:49PM +0100, Maxime Chevallier wrote:
> Preparing the phylink conversion, split the adjust_link callbaclk, by
> clearly separating the mac configuration, link_up and link_down phases.
I'm not entirely sure what the point of this patch is, given that in
patch 7, all this code gets deleted, or maybe moved?
If it's moved, it may be better in patch 7 to ensure that doesn't
happen, and move it in a separate patch - right now patch 7 is horrible
to review as there's no way to see what the changes are in these
link_up()/link_down() functions.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-11-07 17:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 17:02 [PATCH net-next 0/7] net: freescale: ucc_geth: Phylink conversion Maxime Chevallier
2024-11-07 17:02 ` [PATCH net-next 1/7] net: freescale: ucc_geth: Drop support for the "interface" DT property Maxime Chevallier
2024-11-07 17:34 ` Andrew Lunn
2024-11-07 17:02 ` [PATCH net-next 2/7] net: freescale: ucc_geth: split adjust_link for phylink conversion Maxime Chevallier
2024-11-07 17:36 ` Andrew Lunn
2024-11-07 17:51 ` Russell King (Oracle) [this message]
2024-11-07 18:03 ` Maxime Chevallier
2024-11-07 17:02 ` [PATCH net-next 3/7] net: freescale: ucc_geth: Use netdev->phydev to access the PHY Maxime Chevallier
2024-11-07 17:37 ` Andrew Lunn
2024-11-07 17:02 ` [PATCH net-next 4/7] net: freescale: ucc_geth: Fix WOL configuration Maxime Chevallier
2024-11-07 17:49 ` Andrew Lunn
2024-11-07 18:16 ` Maxime Chevallier
2024-11-07 17:02 ` [PATCH net-next 5/7] net: freescale: ucc_geth: Simplify frame length check Maxime Chevallier
2024-11-07 17:50 ` Andrew Lunn
2024-11-07 17:02 ` [PATCH net-next 6/7] net: freescale: ucc_geth: Hardcode the preamble length to 7 bytes Maxime Chevallier
2024-11-07 17:51 ` Andrew Lunn
2024-11-07 17:02 ` [PATCH net-next 7/7] net: freescale: ucc_geth: phylink conversion Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zyz-CcO1inN06mtm@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).