From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Cong Yi <yicong.srfy@foxmail.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Cong Yi <yicong@kylinos.cn>
Subject: Re: [PATCH] net: phylink: Separating two unrelated definitions for improving code readability
Date: Wed, 20 Nov 2024 08:48:55 +0000 [thread overview]
Message-ID: <Zz2id5-T-2-_jj4Q@shell.armlinux.org.uk> (raw)
In-Reply-To: <tencent_9E44A7B2F489B91A12A11C2639C5A4B9F40A@qq.com>
On Wed, Nov 20, 2024 at 02:27:53PM +0800, Cong Yi wrote:
> From: Cong Yi <yicong@kylinos.cn>
>
> After the support of PCS state machine, phylink and pcs two
> unrelated state enum definitions are put together, which brings
> some confusion to code reading.
Hmm, so the definitions being prefixed with "PCS_STATE_" and the
variable being called "pcs_state" isn't enough?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-11-20 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 6:27 [PATCH] net: phylink: Separating two unrelated definitions for improving code readability Cong Yi
2024-11-20 8:48 ` Russell King (Oracle) [this message]
2024-11-20 9:46 ` Cong Yi
2024-11-21 10:50 ` Vladimir Oltean
2024-11-21 11:21 ` Russell King (Oracle)
2024-11-21 11:52 ` Vladimir Oltean
2024-11-21 12:11 ` Russell King (Oracle)
2024-11-21 12:15 ` Vladimir Oltean
2024-11-21 12:26 ` Russell King (Oracle)
2024-11-21 12:47 ` Vladimir Oltean
2024-11-21 12:49 ` Russell King (Oracle)
2024-11-21 12:54 ` Vladimir Oltean
2024-11-21 8:32 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zz2id5-T-2-_jj4Q@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yicong.srfy@foxmail.com \
--cc=yicong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).