From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-b2-smtp.messagingengine.com (flow-b2-smtp.messagingengine.com [202.12.124.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377D319F114; Wed, 20 Nov 2024 11:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732103818; cv=none; b=ifSzzNcuvcMYMShBQVRt9xqpeYjJU3MXTktpADH4nTyELbiVVIJSxz5jjwsoRTTTRnaYToiwmySt57BUTs1PedFVDQQF/nghLbujZ7TUXUwD16U06GhTSK5IYwgYqC5t9gNpEKwM8oeuh+ofZND3QCUieNfksLBX7qwpLo/1wGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732103818; c=relaxed/simple; bh=nXn8VLayjc9h1QTOCTp3FpY6WR+H7Ywm1uuWtcTXJsk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XYqlH7ak5hnRPgbCb+0cdrZzhsD0Sjox8mfLtX6N32bDcYXKCY/dNuPtmr4ugzA3irUDholNieKvxnYiRlYuDoOiSKlUMpiiape1dTK2k5vz8rebUzna47dyJCkszuqMaEtk8XNasuLQh2fmwHDTv1LSfU02LzBS6HxXgWYFQxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=UVHT/tL8; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=IGj11eCc; arc=none smtp.client-ip=202.12.124.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="UVHT/tL8"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="IGj11eCc" Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailflow.stl.internal (Postfix) with ESMTP id EDECE1D406A4; Wed, 20 Nov 2024 06:56:54 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Wed, 20 Nov 2024 06:56:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1732103814; x= 1732107414; bh=3wzTO1++4Ztyr65JdrAwE0ye/gOHnqzkIkXETjXcGRw=; b=U VHT/tL8MEtdmKD525NAXltOXH6qRK+PqpVQ3g0+zNoeXcFXwbCXibJl2r3B3qvCi bXe/HRvFSjfbsASrpumZlwRUffPke+3gGeqwUnfWZbh/rwnZSE+EkFIBsblhYIKR P4bjKqtj4CM0nIWWYDdXXpQU6GbENwLMUwugXevUmwMdrmNu/kMhIXi16MV0mUb2 bdcr8U8JkMvz8tTTOiqruU+z1YPChpXFs6oSnV4zYJNhV3SOrTFy1KuhqFpY/vLK m7pd7/kEe5yYa9dr3U6/LCPCIg0UPkwp83EvO/CA//8gqq6sezAgEn6X2g1UDyTT FlACyFpney0bsPd6npDYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1732103814; x=1732107414; bh=3wzTO1++4Ztyr65JdrAwE0ye/gOHnqzkIkX ETjXcGRw=; b=IGj11eCcS/0X/9SjB3VSzwLtMKQVUi4O2jkSUH8dwH28mwpudES kKtqbRXZP3M/qeWqgDkzbafBFUa09DT3peZW1cBosxWDHZve8pB1mMwDUz/47oq4 KCLt1h8lhXGzEAGyWFUHs1vvVzaxnZdaGtluta0QMxe10gy6/614UaP5ETXidTT9 /l50IC+fSxqBbFfJkY6tea/HAZLRyqla+feqt4KZzYa1yIp3ckXdJil5g0lhzoz5 7Rsq+Z8F5TS+oyTowG4UPewXWeEtdw8fCE/KprSJ9KFJEUzHBmUErvGVI0Re6nq5 TOtT1tjKbuJUxRpOU5Tv5/M5oLVBfdpQGFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrfeeggdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttdejnecu hfhrohhmpefurggsrhhinhgrucffuhgsrhhotggruceoshgusehquhgvrghshihsnhgrih hlrdhnvghtqeenucggtffrrghtthgvrhhnpeeuhffhfffgfffhfeeuiedugedtfefhkeeg teehgeehieffgfeuvdeuffefgfduffenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehsugesqhhuvggrshihshhnrghilhdrnhgvthdpnhgspghr tghpthhtohepuddupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrnhhtohhnih hosehophgvnhhvphhnrdhnvghtpdhrtghpthhtohepvgguuhhmrgiivghtsehgohhoghhl vgdrtghomhdprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoh epphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopeguohhnrghlugdrhhhu nhhtvghrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhhuhgrhheskhgvrhhnvghlrd horhhgpdhrtghpthhtoheprhihrgiirghnohhvrdhsrdgrsehgmhgrihhlrdgtohhmpdhr tghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohepnhgvthguvghvse hvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Nov 2024 06:56:53 -0500 (EST) Date: Wed, 20 Nov 2024 12:56:52 +0100 From: Sabrina Dubroca To: Antonio Quartulli Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Shuah Khan , ryazanov.s.a@gmail.com, Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object Message-ID: References: <20241029-b4-ovpn-v11-0-de4698c73a25@openvpn.net> <20241029-b4-ovpn-v11-6-de4698c73a25@openvpn.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241029-b4-ovpn-v11-6-de4698c73a25@openvpn.net> 2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote: > +/** > + * struct ovpn_peer - the main remote peer object > + * @ovpn: main openvpn instance this peer belongs to > + * @id: unique identifier > + * @vpn_addrs: IP addresses assigned over the tunnel > + * @vpn_addrs.ipv4: IPv4 assigned to peer on the tunnel > + * @vpn_addrs.ipv6: IPv6 assigned to peer on the tunnel > + * @dst_cache: cache for dst_entry used to send to peer > + * @bind: remote peer binding > + * @halt: true if ovpn_peer_mark_delete was called nit: It's initialized to false in ovpn_peer_new, but then never set to true nor read. Drop it? > + * @delete_reason: why peer was deleted (i.e. timeout, transport error, ..) > + * @lock: protects binding to peer (bind) nit: as well as the keepalive values that are introduced later? (I guess the comment should be fixed up in patch 15 when the keepalive mechanism is added) -- Sabrina