From: Pablo Neira Ayuso <pablo@netfilter.org>
To: egyszeregy@freemail.hu
Cc: Florian Westphal <fw@strlen.de>,
kadlec@netfilter.org, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: uapi: Fix file names for case-insensitive filesystem.
Date: Mon, 11 Nov 2024 19:34:45 +0100 [thread overview]
Message-ID: <ZzJORY4eWl4xEiMG@calendula> (raw)
In-Reply-To: <20241111165606.GA21253@breakpoint.cc>
On Mon, Nov 11, 2024 at 05:56:06PM +0100, Florian Westphal wrote:
> egyszeregy@freemail.hu <egyszeregy@freemail.hu> wrote:
> > rename net/ipv4/netfilter/{ipt_ECN.c => ipt_ECN_TARGET.c} (98%)
> > rename net/netfilter/{xt_DSCP.c => xt_DSCP_TARGET.c} (98%)
> > rename net/netfilter/{xt_HL.c => xt_HL_TARGET.c} (100%)
> > rename net/netfilter/{xt_RATEEST.c => xt_RATEEST_TARGET.c} (99%)
> > rename net/netfilter/{xt_TCPMSS.c => xt_TCPMSS_TARGET.c} (99%)
>
> No, please, if we have to do this, then lets merge the targets
> (uppercase name) into the match (lowercase), i.e. most of the contents
> of xt_DSCP.c go into xt_dscp.c.
Agreed, please don't do this.
We have seen people sending patches like this one for several years,
this breaks stuff.
next prev parent reply other threads:[~2024-11-11 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 16:36 [PATCH] netfilter: uapi: Fix file names for case-insensitive filesystem egyszeregy
2024-11-11 16:56 ` Florian Westphal
2024-11-11 18:34 ` Pablo Neira Ayuso [this message]
2024-11-11 20:18 ` Jan Engelhardt
2024-11-11 20:28 ` Szőke Benjamin
2024-11-11 21:16 ` Jan Engelhardt
2024-11-28 22:15 ` Bernd Petrovitsch
2024-11-29 7:08 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzJORY4eWl4xEiMG@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=egyszeregy@freemail.hu \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).