From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org
Subject: Testing selectable timestamping - where are the tools for this feature?
Date: Wed, 13 Nov 2024 14:46:25 +0000 [thread overview]
Message-ID: <ZzS7wWx4lREiOgL3@shell.armlinux.org.uk> (raw)
Hi Kory,
I've finally found some cycles (and time when I'm next to the platform)
to test the selectable timestamping feature. However, I'm struggling to
get it to work.
In your email
https://lore.kernel.org/20240709-feature_ptp_netnext-v17-0-b5317f50df2a@bootlin.com/
you state that "You can test it with the ethtool source on branch
feature_ptp of: https://github.com/kmaincent/ethtool". I cloned this
repository, checked out the feature_ptp branch, and while building
I get the following warnings:
netlink/desc-ethtool.c:241:37: warning: ‘__ts_desc’ defined but not used [-Wunus
ed-const-variable=]
241 | static const struct pretty_nla_desc __ts_desc[] = {
| ^~~~~~~~~
netlink/ts.c: In function ‘ts_get_reply_cb’:
netlink/ts.c:23:14: warning: unused variable ‘str’ [-Wunused-variable]
23 | char str[10] = {'\0'};
| ^~~
ethtool.c:4865:12: warning: ‘do_set_ptp’ defined but not used [-Wunused-functio ]
4865 | static int do_set_ptp(struct cmd_context *ctx)
| ^~~~~~~~~~
ethtool.c:4839:12: warning: ‘do_get_ptp’ defined but not used [-Wunused-functio ]
4839 | static int do_get_ptp(struct cmd_context *ctx)
| ^~~~~~~~~~
ethtool.c:4817:12: warning: ‘do_list_ptp’ defined but not used [-Wunused-function]
4817 | static int do_list_ptp(struct cmd_context *ctx)
| ^~~~~~~~~~~
My conclusion is... your ethtool sources for testing this feature are
broken, or this is no longer the place to test this feature.
Presumably there _is_ something somewhere that allows one to exercise
this new code that Jakub merged on July 15th (commit 30b356005048)?
Please could you point me in the appropriate direction ASAP - time is
very short if I'm going to give this a test on the setup where both
the MAC and PHY support PTP. Essentially, this afternoon - or its
going to be at least a month before the next opportunity.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2024-11-13 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 14:46 Russell King (Oracle) [this message]
2024-11-13 15:16 ` Testing selectable timestamping - where are the tools for this feature? Kory Maincent
2024-11-13 15:57 ` Russell King (Oracle)
2024-11-13 16:14 ` Kory Maincent
2024-11-13 16:41 ` Kory Maincent
2024-11-13 16:52 ` Russell King (Oracle)
2024-11-13 17:02 ` Kory Maincent
2024-11-14 20:20 ` Russell King (Oracle)
2024-11-15 9:11 ` Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzS7wWx4lREiOgL3@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).