From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
netfilter-devel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
coreteam@netfilter.org, netdev@vger.kernel.org,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH nf-next 0/5] netfilter: Prepare netfilter to future .flowi4_tos conversion.
Date: Fri, 15 Nov 2024 11:50:15 +0100 [thread overview]
Message-ID: <ZzcnZ8XvumIbR5mf@calendula> (raw)
In-Reply-To: <cover.1731599482.git.gnault@redhat.com>
On Thu, Nov 14, 2024 at 05:03:16PM +0100, Guillaume Nault wrote:
> There are multiple occasions where Netfilter code needs to perform
> route lookups and initialise struct flowi4. As we're in the process of
> converting the .flowi4_tos field to dscp_t, we need to convert the
> users so that they have a dscp_t value at hand, rather than a __u8.
>
> All netfilter users get the DSCP (TOS) value from IPv4 packet headers.
> So we just need to use the new ip4h_dscp() helper to get a dscp_t
> variable.
>
> Converting .flowi4_tos to dscp_t will allow to detect regressions where
> ECN bits are mistakenly treated as DSCP when doing route lookups.
Series applied, thanks
prev parent reply other threads:[~2024-11-15 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 16:03 [PATCH nf-next 0/5] netfilter: Prepare netfilter to future .flowi4_tos conversion Guillaume Nault
2024-11-14 16:03 ` [PATCH nf-next 1/5] netfilter: ipv4: Convert ip_route_me_harder() to dscp_t Guillaume Nault
2024-11-14 16:03 ` [PATCH nf-next 2/5] netfilter: flow_offload: Convert nft_flow_route() " Guillaume Nault
2024-11-14 16:03 ` [PATCH nf-next 3/5] netfilter: rpfilter: Convert rpfilter_mt() " Guillaume Nault
2024-11-14 16:03 ` [PATCH nf-next 4/5] netfilter: nft_fib: Convert nft_fib4_eval() " Guillaume Nault
2024-11-14 16:03 ` [PATCH nf-next 5/5] netfilter: nf_dup4: Convert nf_dup_ipv4_route() " Guillaume Nault
2024-11-15 10:50 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzcnZ8XvumIbR5mf@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).