From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: manas18244@iiitd.ac.in, Andrew Lunn <andrew@lunn.ch>
Cc: "FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Anup Sharma" <anupnewsmail@gmail.com>,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] rust: simplify Result<()> uses
Date: Sun, 17 Nov 2024 19:12:25 +0000 [thread overview]
Message-ID: <ZzpAGXVfBkJ23gCD@shell.armlinux.org.uk> (raw)
In-Reply-To: <Zzo8Xx9tJdvEO1Q1@shell.armlinux.org.uk>
Let's try that again... with Manas' address pasted in _before_ Andrew's
"A" !
On Sun, Nov 17, 2024 at 06:56:31PM +0000, Russell King (Oracle) wrote:
> On Sun, Nov 17, 2024 at 07:25:48PM +0100, Andrew Lunn wrote:
> > On Sun, Nov 17, 2024 at 08:41:47PM +0530, Manas via B4 Relay wrote:
> > > From: Manas <manas18244@iiitd.ac.in>
> > >
> > > This patch replaces `Result<()>` with `Result`.
> > >
> > > Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> > > Link: https://github.com/Rust-for-Linux/linux/issues/1128
> > > Signed-off-by: Manas <manas18244@iiitd.ac.in>
> > > ---
> > > drivers/net/phy/qt2025.rs | 2 +-
> > > rust/kernel/block/mq/gen_disk.rs | 2 +-
> > > rust/kernel/uaccess.rs | 2 +-
> > > rust/macros/lib.rs | 6 +++---
> >
> > Please split these patches up per subsystem, and submit them
> > individually to the appropriate subsystems.
>
> In addition, it would be good if the commit stated the rationale for
> the change, rather than what the change is (which we can see from the
> patch itself.)
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-11-17 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 15:11 [PATCH] rust: simplify Result<()> uses Manas via B4 Relay
2024-11-17 18:25 ` Andrew Lunn
2024-11-17 18:56 ` Russell King (Oracle)
2024-11-17 19:12 ` Russell King (Oracle) [this message]
2024-11-17 20:49 ` Miguel Ojeda
2024-11-18 0:11 ` Manas
2024-11-18 0:54 ` Miguel Ojeda
2024-11-18 1:11 ` Manas
2024-11-18 9:09 ` Miguel Ojeda
2024-11-18 13:29 ` Andrew Lunn
2024-11-18 14:44 ` Manas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzpAGXVfBkJ23gCD@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=anupnewsmail@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manas18244@iiitd.ac.in \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).