From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94BA21D0B8A; Tue, 19 Nov 2024 20:08:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732046925; cv=none; b=NRP95SWKminuJx7+aBLWxo7q+V/jqzDT1vBo79Vmn57GAZYOGJEZ46UtJ0jCTwwiYa36f5KJ/nFfK5qqt6P08L+98ct2B3qBcYUa2pJTdR/Cn762OtGUkZxNs45FUKr6mAaBVp9G/w3tQ/bd8BCdH7UAqF/gcFxxHnpi4kWOnRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732046925; c=relaxed/simple; bh=lLzg9+6eTjOhVoncCX1Vabji7fScA+C+fCESNgIGa+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BmRfRXmJRtzkWbXkMK9+bAyBafX5hpYTH3Jp1/dqcQouvrXJnkp02CoRk8xPJ54irC0n939TCPySWRyDng1sQpQptYltHC3QJ2rqeEjkrPhIjfdKyoJw9AHIB1TdmRKjQQrPAqGH+0fa0mMfgSMsuOWoVH17qCpLN+ljPUaUbqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=f+e0gTq0; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="f+e0gTq0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=M75wr+RtGR69btb4zt6e59/ZF6kWZbGMj4HSvNiWvzU=; b=f+e0gTq0vLIOgdCVVAy5MBA56G +oGx3wA072dSyK4Tp5LcqUgRzQqPHkpyv2Ma2mhVdCMwwmodTIXnF+NmETti+7WSnr40jH2PQ/NlJ 2QscEibO6cdC85nZidaoFHBUUCGrULKLM/81tcA2qEFsUdEtQchnrISF6aXgfZLGIR6PB9eEm8Gmr wHiGc1xZv4/K4nCGZbdxRLpfegEGXYrRDGuILdFwJkJpTKRsjop4b/NxfGf4iBAuJTTHDKxp/gei9 dl/PXC4Q0FJfSZkgY/3FgqF8XF2X5KkyiHcz1ng9VcDwHEljCqW5wjdVWANPgcWIHx4l7vTqoH9qS IXAhD9zQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:38454) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tDUWO-0004Ky-2Z; Tue, 19 Nov 2024 20:08:25 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tDUWM-0006KU-05; Tue, 19 Nov 2024 20:08:22 +0000 Date: Tue, 19 Nov 2024 20:08:21 +0000 From: "Russell King (Oracle)" To: Daniel Machon Cc: UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , Horatiu Vultur , jacob.e.keller@intel.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 4/8] net: sparx5: use phy_interface_mode_is_rgmii() Message-ID: References: <20241118-sparx5-lan969x-switch-driver-4-v3-0-3cefee5e7e3a@microchip.com> <20241118-sparx5-lan969x-switch-driver-4-v3-4-3cefee5e7e3a@microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241118-sparx5-lan969x-switch-driver-4-v3-4-3cefee5e7e3a@microchip.com> Sender: Russell King (Oracle) Hi, On Mon, Nov 18, 2024 at 02:00:50PM +0100, Daniel Machon wrote: > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c b/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c > index f8562c1a894d..cb55e05e5611 100644 > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c > @@ -32,6 +32,9 @@ sparx5_phylink_mac_select_pcs(struct phylink_config *config, > { > struct sparx5_port *port = netdev_priv(to_net_dev(config->dev)); > > + if (phy_interface_mode_is_rgmii(interface)) > + return NULL; > + > return &port->phylink_pcs; Maybe turn this into positive logic - return the PCS only when the interface mode requires the PCS? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!