From mboxrd@z Thu Jan 1 00:00:00 1970 From: "=?UTF-8?Q?H=C3=A5kon_L=C3=B8vdal?=" Subject: Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a compound statement Date: Tue, 23 Dec 2008 00:44:25 +0100 Message-ID: References: <20081222191259.11807.53190.stgit@vmbox.hanneseder.net> <20081222191507.11807.50794.stgit@vmbox.hanneseder.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Cc: "Hannes Eder" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: "Krzysztof Halasa" Return-path: Received: from mail-gx0-f13.google.com ([209.85.217.13]:65402 "EHLO mail-gx0-f13.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754623AbYLVXo1 (ORCPT ); Mon, 22 Dec 2008 18:44:27 -0500 In-Reply-To: Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: MjAwOC8xMi8yMiBLcnp5c3p0b2YgSGFsYXNhIDxraGNAcG0ud2F3LnBsPjoKPj4gLS0tIGEvZHJp dmVycy9uZXQvc3RhcmZpcmUuYwo+PiArKysgYi9kcml2ZXJzL25ldC9zdGFyZmlyZS5jCj4+IEBA IC04ODIsOSArODgyLDkgQEAgc3RhdGljIGludCBtZGlvX3JlYWQoc3RydWN0IG5ldF9kZXZpY2Ug KmRldiwgaW50IHBoeV9pZCwgaW50IGxvY2F0aW9uKQo+PiAgICAgICB2b2lkIF9faW9tZW0gKm1k aW9fYWRkciA9IG5wLT5iYXNlICsgTUlJQ3RybCArIChwaHlfaWQ8PDcpICsgKGxvY2F0aW9uPDwy KTsKPj4gICAgICAgaW50IHJlc3VsdCwgYm9ndXNjbnQ9MTAwMDsKPj4gICAgICAgLyogPz8/IFNo b3VsZCB3ZSBhZGQgYSBidXN5LXdhaXQgaGVyZT8gKi8KPj4gLSAgICAgZG8KPj4gKyAgICAgZG8g ewo+PiAgICAgICAgICAgICAgIHJlc3VsdCA9IHJlYWRsKG1kaW9fYWRkcik7Cj4+IC0gICAgIHdo aWxlICgocmVzdWx0ICYgMHhDMDAwMDAwMCkgIT0gMHg4MDAwMDAwMCAmJiAtLWJvZ3VzY250ID4g MCk7Cj4+ICsgICAgIH0gd2hpbGUgKChyZXN1bHQgJiAweEMwMDAwMDAwKSAhPSAweDgwMDAwMDAw ICYmIC0tYm9ndXNjbnQgPiAwKTsKPj4gICAgICAgaWYgKGJvZ3VzY250ID09IDApCj4+ICAgICAg ICAgICAgICAgcmV0dXJuIDA7Cj4+ICAgICAgIGlmICgocmVzdWx0ICYgMHhmZmZmKSA9PSAweGZm ZmYpCj4KPgo+IEkgZG9uJ3Qga25vdyBob3cgb25lIGNvdWxkIHRoaW5rIHRoZSBhYm92ZSBpcyBh biBpbXByb3ZlbWVudC4KCkZvciB0aGlzIHNwZWNpZmljIGlzc3VlIHRoZSBpbXBvcnRhbnQgYXNw ZWN0IGlzIHRvIGltcHJvdmUgcmVhZGFiaWxpdHkKKGFuZCBub3QganVzdCBldmVudHVhbGx5IHNh dGlzZnkgc29tZSB3YXJuaW5nIGZyb20gYSB0b29sKSwgd2hpY2ggSQphc3N1bWUgdGhlcmUgaXMg bm8gZGlzYWdyZW1lbnQgb24uIE5vdyB3aGF0IGNvbnN0aXR1dGVzIGltcHJvdmVkCnJlYWRiaWxp dHkgb24gdGhlIG90aGVyIGhhbmQgaXMgYW5vdGhlciBpc3N1ZSwgYW5kIEkgZ3Vlc3MgdGhlcmUg YXJlCm5leHQgdG8gYXMgbWFueSBvcHBpbmlvbnMgYXMgZGV2ZWxvcGVycy4uLiA6KQpJIHdvdWxk IG1vc3QgY2VydGFpbmx5IHByZWZlciB0byBoYXZlIGNvZGUgbG9vayBjb25zaXN0ZW50bHkgYW5k IGFsd2F5cwpoYXZlIGJyYWNrZXRzLCBldmVuIGluIHRoZSBjYXNlIG9mIGp1c3Qgb25lIGJvZHkg bGluZS4KCk9mIHNlY29uZGFyeSBpbXBvcnRhbmNlIGlzIHRoZSBiZW5lZml0IHRoYXQgYWx3YXlz IHVzaW5nIGJyYWNrZXRzCm1ha2VzIHRoZW0gbXVjaCBtb3JlIG1lcmdlIGZyaWVuZGx5LiBDb25z aWRlciB0aGUgZm9sbG93aW5nIHNjZW5hcmlvOgoKQ29tbW9uIGJhc2U6CiAgICAgICAgZG8KICAg ICAgICAgICAgICAgIHJlc3VsdCA9IHJlYWRsKG1kaW9fYWRkcik7CiAgICAgICAgd2hpbGUgKChy ZXN1bHQgJiAweEMwMDAwMDAwKSAhPSAweDgwMDAwMDAwICYmIC0tYm9ndXNjbnQgPiAwKTsKCkJy YW5jaCAxCiAgICAgICAgZG8gewogICAgICAgICAgICAgICAgcmVzdWx0ID0gcmVhZGwobWRpb19h ZGRyKTsKICAgICAgICAgICAgICAgIGRvX3NvbWV0aGluZygpOwogICAgICAgIH0gd2hpbGUgKChy ZXN1bHQgJiAweEMwMDAwMDAwKSAhPSAweDgwMDAwMDAwICYmIC0tYm9ndXNjbnQgPiAwKTsKCkJy YW5jaCAyCiAgICAgICAgZG8KICAgICAgICAgICAgICAgIHJlc3VsdCA9IHJlYWRsKG1kaW9fYWRk cik7CiAgICAgICAgd2hpbGUgKE5PVF9PSyhyZXN1bHQpICYmIC0tYm9ndXNjbnQgPiAwKTsKCklu IHRoaXMgY2FzZSBpZiBib3RoIGJyYW5jaCAxIGFuZCAyIGFyZSBtZXJnZWQsIHRoZXJlIHdpbGwg YmUgYSBtZXJnZSBjb25mbGljdAp0aGF0IGhhcyB0byBiZSByZXNvbHZlZCBtYW51YWxseS4gSWYg dGhlIGJyYWNrZXRzIGhhZCBiZWVuIGluIHBsYWNlIGZyb20gdGhlCnN0YXJ0IHRvb2xzIHNob3Vs ZCBiZSBhYmxlIHRvIHJlc29sdiB0aGlzIGF1dG9tYXRpY2FsbHkuCgpCUiBIw6Vrb24gTMO4dmRh bAo=