From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1105C282D9 for ; Wed, 30 Jan 2019 23:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2FB820881 for ; Wed, 30 Jan 2019 23:03:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kfp62wvj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728715AbfA3XDU (ORCPT ); Wed, 30 Jan 2019 18:03:20 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:33851 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727890AbfA3XDT (ORCPT ); Wed, 30 Jan 2019 18:03:19 -0500 Received: by mail-pg1-f196.google.com with SMTP id j10so497592pga.1 for ; Wed, 30 Jan 2019 15:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=swigyb2iyUrKj564lQMyNvMMgvuYyto/GpSI77aBj2c=; b=kfp62wvj1nSZQcNkslrYH1ZQRNjOjIWvetpL+NvekRmlO0VWsGPER9vwLzRynzOezU K0CW4xVNl5ZEb+N9R+joSVXFxgmUjv3i0nGNQZehME91sxbvnMLa7wKxWToxdMp3XMSo fSAXblgjhnRliVQbvZzlXCA5HPa3BU5H/bVDDR/Kck3yMH0JDN7zNDJf3oq4YUfBe7sY Ri1Cs2T9Q8Kn6QM8A/RDNXhhl8kyeQ3NkhNMrxoIEgjZQn5DPR7ArTgpA8lsgPXaDo9A pKoGSbIRQOY0zd6sHHRXgwdSwRuBKMVlFBx3Xu0112oM8RXsrEC9FpDaMTVvo1tOaMhU 1odg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=swigyb2iyUrKj564lQMyNvMMgvuYyto/GpSI77aBj2c=; b=Flu3p4Fq9ui3QRtFyBSIWwK2Da3iBsaHoavv5UuQ/PeE2n8q2WQOGsaDU6ihP81PHn sQkovN8SpfavtI7c9oqDKsSxPqzJn2NY0cOU3YVBMV7suIaoiPkInMK98e2TinTCx/Ny kAsp34j7JR/HR76VNzLwE1Qnqn2IrSXkhOJ0GGxi66lP8dcItndW1kNHV6rMnP6Ng5Gk KUOFG1FiCTfNfWk+b2IN0EgZRiBHFWQkzR3HiISNoTHc7Fuunl5VD9TtHIG3VYRdmAVl chVDwS2AAnCaDI2x+Ql3DEgy/8i7HZLojK7QQbokkABEZvyeM+AIkqSHvL/tuRsNmZyi jxMg== X-Gm-Message-State: AJcUukffV56JiSIxLPz7KZOSTHLXOSdQLivqkqdCF39lDJ08x++lWPoP 6zVPq2TE9kprWuPi2eNwD0YLJaI+ X-Google-Smtp-Source: ALg8bN7apBdGCmEZ+RK92V+P260P4Kl0pGwl8/IRy0HdASJEBT4KeblXAK1UvKgqa4ZnZqIP4uIDTQ== X-Received: by 2002:a62:2fc3:: with SMTP id v186mr32551305pfv.82.1548887635644; Wed, 30 Jan 2019 14:33:55 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:25a3:bebf:496f:8788? ([2601:282:800:fd80:25a3:bebf:496f:8788]) by smtp.googlemail.com with ESMTPSA id v190sm3457558pfv.26.2019.01.30.14.33.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 14:33:54 -0800 (PST) Subject: Re: [RFC 03/14] net: hstats: add basic/core functionality To: Jakub Kicinski Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org, jiri@resnulli.us, f.fainelli@gmail.com, andrew@lunn.ch, mkubecek@suse.cz, simon.horman@netronome.com, jesse.brandeburg@intel.com, maciejromanfijalkowski@gmail.com, vasundhara-v.volam@broadcom.com, michael.chan@broadcom.com, shalomt@mellanox.com, idosch@mellanox.com References: <20190128234507.32028-1-jakub.kicinski@netronome.com> <20190128234507.32028-4-jakub.kicinski@netronome.com> <20190130094444.204c46b7@cakuba.hsd1.ca.comcast.net> From: David Ahern Message-ID: Date: Wed, 30 Jan 2019 15:33:52 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190130094444.204c46b7@cakuba.hsd1.ca.comcast.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/30/19 10:44 AM, Jakub Kicinski wrote: > On Tue, 29 Jan 2019 21:18:28 -0700, David Ahern wrote: >> On 1/28/19 4:44 PM, Jakub Kicinski wrote: >>> @@ -4946,6 +4964,9 @@ static size_t if_nlmsg_stats_size(const struct net_device *dev, >>> rcu_read_unlock(); >>> } >>> >>> + if (stats_attr_valid(filter_mask, IFLA_STATS_LINK_HSTATS, 0)) >> >> filter_mask is populated by RTEXT_FILTER_ from >> include/uapi/linux/rtnetlink.h > > ext_filter_mask is from IFLA_EXT_MASK and has RTEXT_FILTER_ bits set. > Here the mask is from struct if_stats_msg::filter_mask of RTM_GETSTATS. > Am I missing the point? :S nm. I confused the two filter_mask's. > >>> + size += rtnl_get_link_hstats_size(dev); >> >> rtnl_get_link_hstats_size == __rtnl_get_link_hstats can return < 0. > > Ups! Thank you! > > In general how much do you dislike this code? :) > Not having spent much time on the stats details it is hard to follow - i.e, requires a fair bit of time iterative over the core patches.