netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: makita.toshiaki@lab.ntt.co.jp,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jesper Dangaard Brouer" <brouer@redhat.com>,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: virtio_net: suspicious RCU usage with xdp
Date: Wed, 24 Apr 2019 11:13:42 -0600	[thread overview]
Message-ID: <a03cb5b3-5aa5-7d8f-10db-65d54846807a@gmail.com> (raw)

seeing an RCU warning testing xdp with virtio net. net-next as of commit
b2f97f7de2f6a4df8e431330cf467576486651c5. No obvious changes so hoping
this rings a bell with someone else.


[  121.990304] =============================
[  121.991488] WARNING: suspicious RCU usage
[  121.992392] 5.1.0-rc5+ #60 Not tainted
[  121.993220] -----------------------------
[  121.994158] /home/dsa/kernel-3.git/drivers/net/virtio_net.c:516
suspicious rcu_dereference_check() usage!
[  121.996284]
               other info that might help us debug this:

[  121.997988]
               rcu_scheduler_active = 2, debug_locks = 1
[  121.999321] no locks held by swapper/1/0.
[  122.000328]
               stack backtrace:
[  122.001253] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.1.0-rc5+ #60
[  122.002474] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 1.11.1-1 04/01/2014
[  122.004141] Call Trace:
[  122.004651]  <IRQ>
[  122.005082]  dump_stack+0x7e/0xbb
[  122.005757]  lockdep_rcu_suspicious+0x102/0x10b
[  122.006654]  virtnet_xdp_xmit+0x104/0x4fe
[  122.007447]  ? kasan_check_read+0x11/0x13
[  122.008267]  ? mergeable_rx_buffer_size_show+0x163/0x163
[  122.009299]  ? __asan_loadN+0xf/0x11
[  122.010010]  ? pvclock_clocksource_read+0xfa/0x189
[  122.010975]  bq_xmit_all+0xdc/0x358
[  122.011699]  __dev_map_flush+0xc2/0xef
[  122.012472]  xdp_do_flush_map+0x5b/0x74
[  122.013238]  virtnet_poll+0x58f/0x679

             reply	other threads:[~2019-04-24 18:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 17:13 David Ahern [this message]
2019-04-24 17:37 ` virtio_net: suspicious RCU usage with xdp Michael S. Tsirkin
2019-04-24 17:40   ` David Ahern
2019-04-25  2:56     ` Jason Wang
2019-04-25  2:55   ` Jason Wang
2019-04-25  4:58   ` Toshiaki Makita
2019-04-25 17:03     ` Michael S. Tsirkin
2019-04-25 17:41       ` Jesper Dangaard Brouer
2019-04-25 17:44         ` David Ahern
2019-04-25 18:54           ` Maciej Fijalkowski
2019-04-25 20:04             ` David Ahern
2019-04-25 20:12             ` Jesper Dangaard Brouer
2019-04-26  7:42         ` Toshiaki Makita
2019-04-26  8:00         ` Jason Wang
2019-04-26 11:05           ` Jesper Dangaard Brouer
2019-04-28  3:06             ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a03cb5b3-5aa5-7d8f-10db-65d54846807a@gmail.com \
    --to=dsahern@gmail.com \
    --cc=brouer@redhat.com \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).