From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4FD33BFAC8; Thu, 14 May 2026 13:16:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778764602; cv=none; b=g1oSpx1ntcbHsCNGqjWpw4MSDs/GJ7aCdMkBw3RHhsblDFT7dJKZQgVvsKBTve5iCVeU5uX1fduXpK0duX9hFwedByLsSuOcl2EpESJq9E054maKWVCvaqu4jGoZ0zTTwi0mkrshCbOE6wY+quITBm8IhRFN/g3AwiRdAVNjyzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778764602; c=relaxed/simple; bh=dLQRcRkcA46txUCXuJ2km9A7HIs1N3NYIpzMw9JTGTQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dlFexUF+8NOnw4bUQLjzkmaozeg4yJr15EO38IccbHAjBCNA0d1LxG3txYo23kffk34+cr4a8eQHLulSsW+qbYFpusufGGh9/Gm5HAIaolXk067tAr8dO6sJolOo/79T9B+Cj+Lp7b/xIHlNhXZd/KRT+8DZCXmw9ro7wjoVlkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=RonAfqFn; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="RonAfqFn" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=G4fPOWWTSjI5yvRz5lPq6nB+O5BhDTbqkRTco99Z8Wo=; b=RonAfqFnFtgqoB8ydY6b7UKK0j roADVpo5j+UOfNpWe/5KKxu/bulV/kIWdVSBEe0gL7L0HaAmvGcU1N2oCZ0FMWmyvaJRzsCsod1md C2oF2amkmEVl1+xqG0j2erDdYAVd7RDPVT2YpsisfoCfVfMsgtr1c95bsssqekHy3tX8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wNVvU-002uNe-2w; Thu, 14 May 2026 15:16:32 +0200 Date: Thu, 14 May 2026 15:16:32 +0200 From: Andrew Lunn To: Thangaraj Samynathan Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/5] net: lan743x: Add PCS/XPCS support for SFP on PCI11x1x Message-ID: References: <20260514105028.42942-1-thangaraj.s@microchip.com> <20260514105028.42942-6-thangaraj.s@microchip.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514105028.42942-6-thangaraj.s@microchip.com> > Integrate the XPCS instance with phylink by providing a mac_select_pcs > callback. Support SGMII and 2.5GBASE-X interfaces in phylink Not 1000BaseX? > > switch (adapter->phy_interface) { > case PHY_INTERFACE_MODE_SGMII: > + case PHY_INTERFACE_MODE_2500BASEX: > __set_bit(PHY_INTERFACE_MODE_SGMII, > adapter->phylink_config.supported_interfaces); > __set_bit(PHY_INTERFACE_MODE_1000BASEX, So it looks like there is some sort of mixup with SGMII and 1000BaseX. They are different things. Can adapter->phy_interface be set to PHY_INTERFACE_MODE_1000BASEX? Should there be a case: for it? It could be the broken documentation, using SGMII to mean PCS, has resulted in other problems with 1000BaseX not being implemented correct? You might want to look at all the "SGMII" code and fixup all the 1000BaseX issues. Andrew