From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [bpf-next PATCH v2 0/2] SK_MSG programs: read sock fields Date: Fri, 18 May 2018 23:11:30 +0200 Message-ID: References: <20180517211452.14426.98480.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: John Fastabend , ast@kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:38054 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbeERVLc (ORCPT ); Fri, 18 May 2018 17:11:32 -0400 In-Reply-To: <20180517211452.14426.98480.stgit@john-Precision-Tower-5810> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/17/2018 11:16 PM, John Fastabend wrote: > In this series we add the ability for sk msg programs to read basic > sock information about the sock they are attached to. The second > patch adds the tests to the selftest test_verifier. > > One obseration that I had from writing this seriess is lots of the > ./net/core/filter.c code is almost duplicated across program types. > I thought about building a template/macro that we could use as a > single block of code to read sock data out for multiple programs, > but I wasn't convinced it was worth it yet. The result was using a > macro saved a couple lines of code per block but made the code > a bit harder to read IMO. We can probably revisit the idea later > if we get more duplication. > > v2: add errstr field to negative test_verifier test cases to ensure > we get the expected err string back from the verifier. > > --- > > John Fastabend (2): > bpf: allow sk_msg programs to read sock fields > bpf: add sk_msg prog sk access tests to test_verifier > > > include/linux/filter.h | 1 > include/uapi/linux/bpf.h | 8 ++ > kernel/bpf/sockmap.c | 1 > net/core/filter.c | 114 ++++++++++++++++++++++++++- > tools/include/uapi/linux/bpf.h | 8 ++ > tools/testing/selftests/bpf/test_verifier.c | 115 +++++++++++++++++++++++++++ > 6 files changed, 244 insertions(+), 3 deletions(-) > > -- > Signature > Applied to bpf-next, thanks John!