From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Yash Shah <yash.shah@sifive.com>
Subject: Re: [PATCH] net: macb: fix an issue about leak related to system resources
Date: Sat, 25 Apr 2020 19:00:35 +0200 [thread overview]
Message-ID: <a0891e70-d39f-7822-f81a-04eb824c6fd0@web.de> (raw)
> A call of the function macb_init() can fail in the function
> fu540_c000_init. The related system resources were not released
> then. use devm_ioremap() to replace ioremap() for fix it.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] net: macb: Use devm_ioremap() in fu540_c000_init()
Change description:
A call of the macb_init() function can fail here.
The corresponding system resources were not released then.
Thus replace a call of the ioremap() function by devm_ioremap().
Regards,
Markus
next reply other threads:[~2020-04-25 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 17:00 Markus Elfring [this message]
2020-04-26 2:53 ` [PATCH] net: macb: fix an issue about leak related to system resources Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0891e70-d39f-7822-f81a-04eb824c6fd0@web.de \
--to=markus.elfring@web.de \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=yash.shah@sifive.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox