Re: [PATCH v2 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3

[Denis Efremov <denis.e.efremov@oracle.com>]

Hi,

On 4/1/22 22:09, Martin Faltesek wrote:
> Changes in v2:
>         -- Split the original patch into 3 patches, so that each one solves
>            a single issue. The original patch indicated 4 bugs, but two are
>            so closely related that I feel it makes sense to keep them
>            together.
> 
>         -- 1/3
>            nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
> 
>            This is mentioned in v1 as #1.  It just changes logical AND to
>            logical OR. The AND was rendering the check useless.
> 
>         -- 2/3
>            nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
> 
>            This is from v1 #3.
> 
>         -- 3/3
>            nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
> 
>            This is from v1 #2 and #4
>            Both are derived from the same bug, which is the incorrect calculation
>            that buffer allocation size is skb->len - 2, so both should be combined.
> 
>         After these 3 patches are applied, the end result is the same as v1
>         except:
> 
>         -- minor comment rewording.
>         -- removed some comments which felt superfluous explanations of
>            obvious code.
> 
> Martin Faltesek (3):
>   nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
>   nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
>   nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION
> 
>  drivers/nfc/st21nfca/se.c | 51 +++++++++++++++++++++++----------------
>  1 file changed, 30 insertions(+), 21 deletions(-)
> 

Ping?

Denis