From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A63C282C4 for ; Tue, 5 Feb 2019 03:21:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C83820815 for ; Tue, 5 Feb 2019 03:21:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AfLS99Iq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726646AbfBEDVS (ORCPT ); Mon, 4 Feb 2019 22:21:18 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:47068 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfBEDVR (ORCPT ); Mon, 4 Feb 2019 22:21:17 -0500 Received: by mail-pf1-f194.google.com with SMTP id c73so856126pfe.13 for ; Mon, 04 Feb 2019 19:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3uvLSqDl3Ja/I45+aZRPPr854r7TIsHqIbUJNX2Lr54=; b=AfLS99IqNJEPoHyUntnivIPlAymXa5B95imyQmK3R6bcsnRSopVvIm1aAF0WLqZXBM N1pGhy9tiNQYqbkJ3qy2xU5KQPkMWyNsYSFCL6tIwXA7P0oLpOCkUlRm87tYra8SW7jH 945hc4ImwovZDLPKop+P+aPRZQYkmiadi7OJX/LZ/ZLyYSiypCFAg4aKMDqL6T+j0y3B fIO2J0azU7NTTpz5GDuyzWhyq3emajQCoy9J0mTlL0Kx7kPQpIeGyC++6iqtKtD+Qado g857BV94PCsJB/GT2vQGRjkQal0pnGIIknIqWhpCtNqzvsxe3mwG2P9paZoIR0dEVLDP Tdyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3uvLSqDl3Ja/I45+aZRPPr854r7TIsHqIbUJNX2Lr54=; b=jk429oSh95rI1IWREK2bd28svn7R3GKcuVcEb91lBrsTWXaYc9G7XV883qvZ8UCeJz UtGsrUlfIcv0UxwyLVXBNEyzWOW0Ti6rJqQbKDc7s4HZi9VPrT/AtqARLDhByjw5N22W CUGvsi7wrYZ6A2rTE6snECi9PeQAEnx3sHpf1SWXve03bbKF2Y5ovpcT+iRy9iE14kwQ CeIY+FcRjyphY61PDX+4ZR6p7UVgzo8b4p3EyOoV0WY9qb3cQXR6UIzVp8QKhDgezGEo h94RihTsMsxg5lLH+PaZJxTfDSzX2oE5uH1yxcjVJYROUvMwqp0/jBdS5+ThKDtw5NNr h2OA== X-Gm-Message-State: AHQUAuZPatC+D/IvGO3snywBQkE41m33UpaHRIw5Wpm3qdOYp25Hbfsp J2e64nGcJatKGr4UnDJeESw= X-Google-Smtp-Source: AHgI3IZtOestlCT9vZ9+QFPOglL+ZqmyWBUrGZkyKJjY1hxGAAGHjKrTFD5yhLUJVBmCjsElUlOcZg== X-Received: by 2002:a63:6984:: with SMTP id e126mr2577552pgc.143.1549336877167; Mon, 04 Feb 2019 19:21:17 -0800 (PST) Received: from [172.27.227.2] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id d69sm1976040pfg.168.2019.02.04.19.21.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 19:21:16 -0800 (PST) Subject: Re: [PATCH] net: fix IPv6 prefix route residue To: David Miller , liuzhiqiang26@huawei.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, 0xeffeff@gmail.com, edumazet@google.com, netdev@vger.kernel.org, mingfangsen@huawei.com, zhangwenhao8@huawei.com, wangxiaogang3@huawei.com, zhoukang7@huawei.com References: <98d563a5-34f0-a504-d62f-d20ed7c770da@huawei.com> <20190203.090411.1685970814345088903.davem@redhat.com> From: David Ahern Message-ID: Date: Mon, 4 Feb 2019 19:21:13 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190203.090411.1685970814345088903.davem@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/3/19 9:04 AM, David Miller wrote: > From: Zhiqiang Liu > Date: Sun, 3 Feb 2019 14:10:31 +0800 > >> @@ -1165,7 +1165,8 @@ enum cleanup_prefix_rt_t { >> list_for_each_entry(ifa, &idev->addr_list, if_list) { >> if (ifa == ifp) >> continue; >> - if (!ipv6_prefix_equal(&ifa->addr, &ifp->addr, >> + if (ifa->prefix_len != ifp->prefix_len || >> + !ipv6_prefix_equal(&ifa->addr, &ifp->addr, >> ifp->prefix_len)) > > Please fix the indentation of this conditional, it should be: > > if (ifa->prefix_len != ifp->prefix_len || > !ipv6_prefix_equal(&ifa->addr, &ifp->addr, > ifp->prefix_len)) > > Thank you. > Needs a Fixes tag too. Fixes: 5b84efecb7d9 ("ipv6 addrconf: don't cleanup prefix route for IFA_F_NOPREFIXROUTE") and cc to that author Thomas Haller