Netdev List
 help / color / mirror / Atom feed
From: Matthias Rosenfelder <mrosenfelder.lkml@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, dan.carpenter@oracle.com, davejwatson@fb.com
Subject: [RFC] tls: length check correct in do_tls_getsockopt_tx()?
Date: Wed, 5 Jul 2017 03:10:53 -0400	[thread overview]
Message-ID: <a0dac911-6401-12cb-611c-5a1723d943c1@gmail.com> (raw)

Hi,

In do_tls_getsockopt_tx():

if (len == sizeof(crypto_info)) {

should be

if (len == sizeof(*crypto_info)) {

as crypto_info is of pointer type. Or am I missing something?


btw: I am not very familiar with sockets. So I am wondering
what is the use of this functionality? Why copy only the header
to userspace?


Thanks.
Best Regards,

Matthias

             reply	other threads:[~2017-07-05  7:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05  7:10 Matthias Rosenfelder [this message]
2017-07-05 10:17 ` [RFC] tls: length check correct in do_tls_getsockopt_tx()? Dan Carpenter
2017-07-05 11:07   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0dac911-6401-12cb-611c-5a1723d943c1@gmail.com \
    --to=mrosenfelder.lkml@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davejwatson@fb.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox