From: David Ahern <dsahern@kernel.org>
To: Coco Li <lixiaoyan@google.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Mubashir Adnan Qureshi <mubashirq@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Chao Wu <wwchao@google.com>,
Wei Wang <weiwan@google.com>
Subject: Re: [PATCH v1 net-next 4/5] net-device: reorganize net_device fast path variables
Date: Fri, 15 Sep 2023 21:17:18 -0600 [thread overview]
Message-ID: <a0dfabb8-2243-0cf7-2fab-ccc1b58bd9d3@kernel.org> (raw)
In-Reply-To: <20230916010625.2771731-5-lixiaoyan@google.com>
On 9/15/23 7:06 PM, Coco Li wrote:
> Reorganize fast path variables on tx-txrx-rx order
> Fastpath variables end after npinfo.
>
> Below data generated with pahole on x86 architecture.
>
> Fast path variables span cache lines before change: 12
> Fast path variables span cache lines after change: 4
>
> Tested:
> Built and installed.
>
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> ---
> include/linux/netdevice.h | 96 +++++++++++++++++++--------------------
> 1 file changed, 48 insertions(+), 48 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-09-16 3:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 1:06 [PATCH v1 net-next 0/5] Analyze and Reorganize core Networking Structs to optimize cacheline consumption Coco Li
2023-09-16 1:06 ` [PATCH v1 net-next 1/5] Documentations: Analyze heavily used Networking related structs Coco Li
2023-09-16 14:36 ` Andrew Lunn
2023-09-21 6:38 ` Coco Li
2023-10-04 13:37 ` Jakub Kicinski
2023-10-04 13:41 ` Jakub Kicinski
2023-10-17 1:37 ` Coco Li
2023-09-16 1:06 ` [PATCH v1 net-next 2/5] net-smnp: reorganize SNMP fast path variables Coco Li
2023-09-16 3:16 ` David Ahern
2023-09-16 14:39 ` Andrew Lunn
2023-09-16 1:06 ` [PATCH v1 net-next 3/5] netns-ipv4: reorganize netns_ipv4 " Coco Li
2023-09-16 3:17 ` David Ahern
2023-09-17 17:10 ` Vadim Fedorenko
2023-09-21 6:31 ` Coco Li
2023-09-16 1:06 ` [PATCH v1 net-next 4/5] net-device: reorganize net_device " Coco Li
2023-09-16 3:17 ` David Ahern [this message]
2023-09-18 19:50 ` Eric Dumazet
2023-09-16 1:06 ` [PATCH v1 net-next 5/5] tcp: reorganize tcp_sock " Coco Li
2023-09-16 3:17 ` David Ahern
2023-09-16 3:20 ` [PATCH v1 net-next 0/5] Analyze and Reorganize core Networking Structs to optimize cacheline consumption David Ahern
2023-09-16 14:23 ` Andrew Lunn
2023-09-21 6:47 ` Coco Li
2023-10-17 1:41 ` Coco Li
2023-10-17 11:26 ` Sunil Kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0dfabb8-2243-0cf7-2fab-ccc1b58bd9d3@kernel.org \
--to=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=mubashirq@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
--cc=wwchao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).