From: Andrew Lunn <andrew@lunn.ch>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org, linux@armlinux.org.uk,
hkallweit1@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net,
pabeni@redhat.com, kuba@kernel.org, kernel-team@meta.com,
edumazet@google.com
Subject: Re: [net-next PATCH v2 5/6] fbnic: Add support for reporting link config
Date: Sun, 15 Jun 2025 00:27:22 +0200 [thread overview]
Message-ID: <a0f564fe-9d0a-4ebb-937c-e2256f8929bb@lunn.ch> (raw)
In-Reply-To: <174974093397.3327565.18236629132584929783.stgit@ahduyck-xeon-server.home.arpa>
> +static void
> +fbnic_phylink_set_supported_fec_modes(unsigned long *supported)
> +{
I know naming is hard, but can this be called
fbnic_phylink_get_supported_fec_modes() because ...
> +int fbnic_phylink_ethtool_ksettings_get(struct net_device *netdev,
> + struct ethtool_link_ksettings *cmd)
> +{
> + struct fbnic_net *fbn = netdev_priv(netdev);
> + int err;
> +
> + err = phylink_ethtool_ksettings_get(fbn->phylink, cmd);
> + if (!err) {
> + unsigned long *supp = cmd->link_modes.supported;
> +
> + cmd->base.port = PORT_DA;
> + cmd->lanes = (fbn->aui & FBNIC_AUI_MODE_R2) ? 2 : 1;
> +
> + fbnic_phylink_set_supported_fec_modes(supp);
... calling a _set_ function in ksettings_get() looks odd.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-06-14 22:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 15:08 [net-next PATCH v2 0/6] Add support for 25G, 50G, and 100G to fbnic Alexander Duyck
2025-06-12 15:08 ` [net-next PATCH v2 1/6] net: phy: Add interface types for 50G and 100G Alexander Duyck
2025-06-12 15:08 ` [net-next PATCH v2 2/6] fbnic: Do not consider mailbox "initialized" until we have verified fw version Alexander Duyck
2025-06-12 15:08 ` [net-next PATCH v2 3/6] fbnic: Replace 'link_mode' with 'aui' Alexander Duyck
2025-06-16 15:34 ` Simon Horman
2025-06-16 16:14 ` Alexander Duyck
2025-06-17 7:00 ` Simon Horman
2025-06-12 15:08 ` [net-next PATCH v2 4/6] fbnic: Set correct supported modes and speeds based on FW setting Alexander Duyck
2025-06-12 15:08 ` [net-next PATCH v2 5/6] fbnic: Add support for reporting link config Alexander Duyck
2025-06-14 22:27 ` Andrew Lunn [this message]
2025-06-12 15:09 ` [net-next PATCH v2 6/6] fbnic: Add support for setting/getting pause configuration Alexander Duyck
2025-06-14 22:29 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0f564fe-9d0a-4ebb-937c-e2256f8929bb@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.duyck@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).