From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0368C4167B for ; Thu, 24 Feb 2022 09:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232538AbiBXJJK (ORCPT ); Thu, 24 Feb 2022 04:09:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232539AbiBXJJG (ORCPT ); Thu, 24 Feb 2022 04:09:06 -0500 X-Greylist: delayed 428 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 24 Feb 2022 01:08:31 PST Received: from blyat.fensystems.co.uk (blyat.fensystems.co.uk [IPv6:2a05:d018:a4d:6403:2dda:8093:274f:d185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35DBE19E011; Thu, 24 Feb 2022 01:08:30 -0800 (PST) Received: from pudding.home (unknown [IPv6:2a00:23c6:5486:8700:eaa7:4ea6:88e4:6f0e]) by blyat.fensystems.co.uk (Postfix) with ESMTPSA id 314E643912; Thu, 24 Feb 2022 09:01:17 +0000 (UTC) Subject: Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status existence before watching" To: paul@xen.org, =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Wei Liu , "David S. Miller" , Jakub Kicinski , "moderated list:XEN NETWORK BACKEND DRIVER" , "open list:XEN NETWORK BACKEND DRIVER" References: <20220222001817.2264967-1-marmarek@invisiblethingslab.com> <20220222001817.2264967-2-marmarek@invisiblethingslab.com> From: Michael Brown Message-ID: Date: Thu, 24 Feb 2022 09:01:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 24/02/2022 07:56, Durrant, Paul wrote: > On 22/02/2022 00:18, Marek Marczykowski-Górecki wrote: >> This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. >> >> The reasoning in the commit was wrong - the code expected to setup the >> watch even if 'hotplug-status' didn't exist. In fact, it relied on the >> watch being fired the first time - to check if maybe 'hotplug-status' is >> already set to 'connected'. Not registering a watch for non-existing >> path (which is the case if hotplug script hasn't been executed yet), >> made the backend not waiting for the hotplug script to execute. This in >> turns, made the netfront think the interface is fully operational, while >> in fact it was not (the vif interface on xen-netback side might not be >> configured yet). >> >> This was a workaround for 'hotplug-status' erroneously being removed. >> But since that is reverted now, the workaround is not necessary either. >> >> More discussion at >> https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u >> >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Marek Marczykowski-Górecki >> > > Reviewed-by: Paul Durrant In conjunction with patch 1/2 (which reverts the patch that caused the original problem): Reviewed-by: Michael Brown Thanks, Michael