From: Andrew Lunn <andrew@lunn.ch>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yao Zi <me@ziyao.cc>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1] net: stmmac: Default DWMAC_MOTORCOMM to m on MACH_LOONGSON64
Date: Thu, 17 Sep 2026 16:45:41 +0200 [thread overview]
Message-ID: <a10c8361-648e-476b-8b04-8716ad274fc4@lunn.ch> (raw)
In-Reply-To: <f6b93b98-e0d3-9e28-e366-4df126e6ab5f@loongson.cn>
> Before moving forward, I'd like to share an alternative thought.
> As noted in the earlier review, this network controller could be
> used across multiple architectures. To avoid the redundant churn
> in the defconfigs of every single architecture, I am wondering if
> we could unconditionally set it to default m in the Kconfig instead.
~/linux/drivers/net/ethernet/stmicro/stmmac$ grep default Kconfig
default n
default y
default STMMAC_PLATFORM
default ARC
default MACH_INGENIC
default ARCH_QCOM
default ARCH_LPC18XX
default ARCH_MESON
default ARCH_MA35
default ARCH_QCOM
default ARCH_RENESAS
default ARCH_ROCKCHIP
default ARCH_RZN1
default ARCH_S32
default ARCH_INTEL_SOCFPGA
default m if ARCH_SOPHGO
default m if ARCH_SPACEMIT
default m if ARCH_STARFIVE
default ARCH_STI
default ARCH_STM32
default ARCH_SUNXI
default ARCH_SUNXI
default ARCH_SUNXI
default ARCH_MXC
default MACH_LOONGSON32
default ARCH_VISCONTI
default X86
default MACH_LOONGSON64
No other glue driver does this. Why is this one special?
Andrew
next prev parent reply other threads:[~2026-09-17 14:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 7:32 [PATCH net-next v1] net: stmmac: Default DWMAC_MOTORCOMM to m on MACH_LOONGSON64 Tiezhu Yang
2026-09-16 16:49 ` Yao Zi
2026-09-16 16:54 ` Maxime Chevallier
2026-09-17 1:01 ` Tiezhu Yang
2026-09-17 14:45 ` Andrew Lunn [this message]
2026-09-18 6:48 ` Tiezhu Yang
2026-09-18 7:10 ` Yao Zi
2026-09-18 11:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a10c8361-648e-476b-8b04-8716ad274fc4@lunn.ch \
--to=andrew@lunn.ch \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=me@ziyao.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox