From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1783EC4727E for ; Thu, 1 Oct 2020 20:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD38C20738 for ; Thu, 1 Oct 2020 20:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733002AbgJAUtC (ORCPT ); Thu, 1 Oct 2020 16:49:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732836AbgJAUtB (ORCPT ); Thu, 1 Oct 2020 16:49:01 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA356C0613D0 for ; Thu, 1 Oct 2020 13:49:01 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kO5Vb-00EoRg-UR; Thu, 01 Oct 2020 22:49:00 +0200 Message-ID: Subject: Re: [PATCH net-next 7/9] taskstats: move specifying netlink policy back to ops From: Johannes Berg To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, andrew@lunn.ch, jiri@resnulli.us, mkubecek@suse.cz, dsahern@kernel.org, pablo@netfilter.org, bsingharora@gmail.com Date: Thu, 01 Oct 2020 22:48:58 +0200 In-Reply-To: <20201001183016.1259870-8-kuba@kernel.org> References: <20201001183016.1259870-1-kuba@kernel.org> <20201001183016.1259870-8-kuba@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > @@ -44,7 +44,7 @@ static const struct nla_policy taskstats_cmd_get_policy[TASKSTATS_CMD_ATTR_MAX+1 > * We have to use TASKSTATS_CMD_ATTR_MAX here, it is the maxattr in the family. > * Make sure they are always aligned. > Probably worth also removing/updating the comments? But otherwise, Reviewed-by: Johannes Berg and I think that is much better than the hacks I put there at the time, and also of course better than what it had originally without a per-op maxattr. :) johannes