From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive Date: Wed, 25 Jan 2017 10:57:12 +0800 Message-ID: References: <20170117221443.20280.62546.stgit@john-Precision-Tower-5810> <20170117221950.20280.39496.stgit@john-Precision-Tower-5810> <20170123230809-mutt-send-email-mst@kernel.org> <20170124.144328.2195698124358175034.davem@davemloft.net> <20170124215412-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: john.fastabend@gmail.com, john.r.fastabend@intel.com, netdev@vger.kernel.org, alexei.starovoitov@gmail.com, daniel@iogearbox.net To: "Michael S. Tsirkin" , David Miller Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44268 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbdAYC5T (ORCPT ); Tue, 24 Jan 2017 21:57:19 -0500 In-Reply-To: <20170124215412-mutt-send-email-mst@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On 2017年01月25日 04:08, Michael S. Tsirkin wrote: > On Tue, Jan 24, 2017 at 02:43:28PM -0500, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Mon, 23 Jan 2017 23:08:35 +0200 >> >>> On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: >>>> In the small buffer case during driver unload we currently use >>>> put_page instead of dev_kfree_skb. Resolve this by adding a check >>>> for virtnet mode when checking XDP queue type. Also name the >>>> function so that the code reads correctly to match the additional >>>> check. >>>> >>>> Fixes: bb91accf2733 ("virtio-net: XDP support for small buffers") >>>> Signed-off-by: John Fastabend >>>> Acked-by: Jason Wang >>> Acked-by: Michael S. Tsirkin >>> >>> I think we definitely want this one in -net as it's >>> a bugfix. >> This whole series is a bug fix, we must have adjust_header XDP >> support in the virtio_net driver before v4.10 goes out, it is >> a requires base feature for XDP. > I have to say device resets outside probe have a huge potential > to uncover hypervisor bugs. Maybe not if it reuses most of current codes? Since we've already used them in sleep or hibernation? Thanks > I am rather uncomfortable > doing that after -rc1. > > How about a module option to disable it by default? > We can then ship a partial implementation in 4.10 > and work on completing it in 4.11. >