From: Florian Fainelli <f.fainelli@gmail.com>
To: Oded Gabbay <oded.gabbay@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, SW_Drivers <SW_Drivers@habana.ai>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 00/15] Adding GAUDI NIC code to habanalabs driver
Date: Thu, 10 Sep 2020 14:05:15 -0700 [thread overview]
Message-ID: <a13199ce-0c73-920d-857d-3223144f41f0@gmail.com> (raw)
In-Reply-To: <CAFCwf127fssgiDEwYvv3rFW7iFFfKKZDE=oxDUbFBcwpz3yQkQ@mail.gmail.com>
On 9/10/2020 1:32 PM, Oded Gabbay wrote:
> On Thu, Sep 10, 2020 at 11:28 PM Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Thu, 10 Sep 2020 23:16:22 +0300 Oded Gabbay wrote:
>>> On Thu, Sep 10, 2020 at 11:01 PM Jakub Kicinski <kuba@kernel.org> wrote:
>>>> On Thu, 10 Sep 2020 19:11:11 +0300 Oded Gabbay wrote:
>>>>> create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic.c
>>>>> create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic.h
>>>>> create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic_dcbnl.c
>>>>> create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic_debugfs.c
>>>>> create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_nic_ethtool.c
>>>>> create mode 100644 drivers/misc/habanalabs/gaudi/gaudi_phy.c
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_qm0_masks.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_qm0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_qm1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_qpc0_masks.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_qpc0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_qpc1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_rxb_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_rxe0_masks.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_rxe0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_rxe1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_stat_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_tmr_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_txe0_masks.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_txe0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_txe1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_txs0_masks.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_txs0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic0_txs1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic1_qm0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic1_qm1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic2_qm0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic2_qm1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic3_qm0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic3_qm1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic4_qm0_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/gaudi/asic_reg/nic4_qm1_regs.h
>>>>> create mode 100644 drivers/misc/habanalabs/include/hw_ip/nic/nic_general.h
>>>>
>>>> The relevant code needs to live under drivers/net/(ethernet/).
>>>> For one thing our automation won't trigger for drivers in random
>>>> (/misc) part of the tree.
>>>
>>> Can you please elaborate on how to do this with a single driver that
>>> is already in misc ?
>>> As I mentioned in the cover letter, we are not developing a
>>> stand-alone NIC. We have a deep-learning accelerator with a NIC
>>> interface.
>>> Therefore, we don't have a separate PCI physical function for the NIC
>>> and I can't have a second driver registering to it.
>>
>> Is it not possible to move the files and still build them into a single
>> module?
> hmm...
> I actually didn't try that as I thought it will be very strange and
> I'm not familiar with other drivers that build as a single ko but have
> files spread out in different subsystems.
> I don't feel it is a better option than what we did here.
>
> Will I need to split pull requests to different subsystem maintainers
> ? For the same driver ?
> Sounds to me this is not going to fly.
Not necessarily, you can post your patches to all relevant lists and
seek maintainer review/acked-by tags from the relevant maintainers. This
is not unheard of with mlx5 for instance.
Have you considered using notifiers to get your NIC driver registered
while the NIC code lives in a different module?
--
Florian
next prev parent reply other threads:[~2020-09-10 21:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 16:11 [PATCH 00/15] Adding GAUDI NIC code to habanalabs driver Oded Gabbay
2020-09-10 16:11 ` [PATCH 01/15] habanalabs/gaudi: add NIC H/W and registers definitions Oded Gabbay
2020-09-10 16:11 ` [PATCH 02/15] habanalabs/gaudi: add NIC firmware-related definitions Oded Gabbay
2020-09-10 16:11 ` [PATCH 03/15] habanalabs/gaudi: add NIC security configuration Oded Gabbay
2020-09-10 16:11 ` [PATCH 04/15] habanalabs/gaudi: add support for NIC QMANs Oded Gabbay
2020-09-10 16:11 ` [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support Oded Gabbay
2020-09-10 20:03 ` Jakub Kicinski
2020-09-10 20:18 ` Oded Gabbay
2020-09-14 9:52 ` Omer Shpigelman
2020-09-14 16:47 ` Jakub Kicinski
2020-09-10 16:11 ` [PATCH 06/15] habanalabs/gaudi: add NIC PHY code Oded Gabbay
2020-09-10 16:11 ` [PATCH 07/15] habanalabs/gaudi: allow user to get MAC addresses in INFO IOCTL Oded Gabbay
2020-09-10 16:11 ` [PATCH 08/15] habanalabs/gaudi: add a new IOCTL for NIC control operations Oded Gabbay
2020-09-10 16:11 ` [PATCH 09/15] habanalabs/gaudi: add CQ " Oded Gabbay
2020-09-10 16:11 ` [PATCH 10/15] habanalabs/gaudi: add WQ " Oded Gabbay
2020-09-10 16:11 ` [PATCH 11/15] habanalabs/gaudi: add QP error handling Oded Gabbay
2020-09-10 16:11 ` [PATCH 12/15] habanalabs/gaudi: add debugfs entries for the NIC Oded Gabbay
2020-09-10 20:01 ` Jakub Kicinski
2020-09-10 20:10 ` Oded Gabbay
2020-09-10 20:16 ` Jakub Kicinski
2020-09-10 20:17 ` Oded Gabbay
2020-09-10 20:30 ` Jakub Kicinski
2020-09-10 20:33 ` Oded Gabbay
2020-09-14 13:48 ` Omer Shpigelman
2020-09-14 16:50 ` Jakub Kicinski
2020-09-15 12:57 ` Oded Gabbay
2020-09-16 16:38 ` Jakub Kicinski
2020-09-10 16:11 ` [PATCH 13/15] habanalabs/gaudi: Add ethtool support using coresight Oded Gabbay
2020-09-10 20:19 ` Andrew Lunn
2020-09-10 20:22 ` Oded Gabbay
2020-09-10 16:11 ` [PATCH 14/15] habanalabs/gaudi: support DCB protocol Oded Gabbay
2020-09-10 16:11 ` [PATCH 15/15] habanalabs/gaudi: add NIC init/fini calls from common code Oded Gabbay
2020-09-10 20:01 ` [PATCH 00/15] Adding GAUDI NIC code to habanalabs driver Jakub Kicinski
2020-09-10 20:16 ` Oded Gabbay
2020-09-10 20:25 ` Andrew Lunn
2020-09-10 20:30 ` Oded Gabbay
2020-09-10 20:38 ` Andrew Lunn
2020-09-10 20:52 ` Oded Gabbay
2020-09-11 6:22 ` Greg Kroah-Hartman
2020-09-10 20:28 ` Jakub Kicinski
2020-09-10 20:32 ` Oded Gabbay
2020-09-10 21:05 ` Florian Fainelli [this message]
2020-09-10 21:15 ` Oded Gabbay
2020-09-10 21:23 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a13199ce-0c73-920d-857d-3223144f41f0@gmail.com \
--to=f.fainelli@gmail.com \
--cc=SW_Drivers@habana.ai \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).