From: David Ahern <dsahern@gmail.com>
To: Yajun Deng <yajun.deng@linux.dev>, davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] neigh: introduce __neigh_confirm() for __ipv{4, 6}_confirm_neigh
Date: Wed, 17 Nov 2021 12:34:41 -0700 [thread overview]
Message-ID: <a15db099-a83f-69bd-2cbb-420055087904@gmail.com> (raw)
In-Reply-To: <20211117120215.30209-1-yajun.deng@linux.dev>
On 11/17/21 5:02 AM, Yajun Deng wrote:
> - unsigned long now = jiffies;
> -
> - /* avoid dirtying neighbour */
> - if (READ_ONCE(n->confirmed) != now)
> - WRITE_ONCE(n->confirmed, now);
Just move this part to neigh_confirm and leave the rest as it is. That
READ_ONCE, WRITE_ONCE pair exists in other places that could use the
neigh_confirm style helper.
prev parent reply other threads:[~2021-11-17 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 12:02 [PATCH net-next] neigh: introduce __neigh_confirm() for __ipv{4, 6}_confirm_neigh Yajun Deng
2021-11-17 17:36 ` Eric Dumazet
2021-11-18 2:24 ` yajun.deng
2021-11-17 19:34 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a15db099-a83f-69bd-2cbb-420055087904@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).