From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close() Date: Fri, 18 May 2018 20:28:05 +0300 Message-ID: References: <20180517163732.30910-1-jeffrey.t.kirsher@intel.com> <20180517163732.30910-4-jeffrey.t.kirsher@intel.com> <9ee4abce-0841-374d-5395-0c5170880eb1@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com To: Pavel Tatashin , Jeff Kirsher , davem@davemloft.net Return-path: Received: from mail-lf0-f66.google.com ([209.85.215.66]:39646 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbeERR2J (ORCPT ); Fri, 18 May 2018 13:28:09 -0400 Received: by mail-lf0-f66.google.com with SMTP id j193-v6so15057189lfg.6 for ; Fri, 18 May 2018 10:28:09 -0700 (PDT) In-Reply-To: <9ee4abce-0841-374d-5395-0c5170880eb1@oracle.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 05/18/2018 02:37 PM, Pavel Tatashin wrote: > * parallelized this function, so drop lock for the >> >> Parallelizing? Else the sentence doesn't parse for me. :-) My comment hardly makes sense when you removed all the context... > Hi Sergei, > > In a separate series I parallelized device_shutdown(), see: > http://lkml.kernel.org/r/20180516024004.28977-1-pasha.tatashin@oracle.com > > But, this particular patch should be dropped, as discussed in this thread: > http://lkml.kernel.org/r/20180503035931.22439-2-pasha.tatashin@oracle.com > > > Alexander Duyck, made a point that a generic RTNL scalability fix should be done. This particular patch might introduce a race, since it relies on assumption that RTNL is not needed in this place because ixgbe_close() does not have it, but Alexander Duyck, says that the callers of ixgbe_close() are assumed to own this lock. My comment was about the English grammar only. :-) > Thank you, > Pavel MBR, Sergei