From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dalon Westergreen <dwesterg@gmail.com>
Subject: Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp
 and timestamping
Date: Fri, 16 Nov 2018 05:33:36 -0800
Message-ID: <a17d27ee523ec6be3810effa7fabb3e2353ecd63.camel@gmail.com>
References: <20181115005047.28464-1-dwesterg@gmail.com>
         <20181115005047.28464-7-dwesterg@gmail.com>
         <20181115032411.bh6dxqh44iqap4vt@localhost>
         <729c71a95091f0902396be8b6c73409cd1e8ae9d.camel@gmail.com>
         <20181116021418.dhbw5cu4y56cfjls@localhost>
Reply-To: dwesterg@gmail.com
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, dinguyen@kernel.org,
        thor.thayer@linux.intel.com
To: Richard Cochran <richardcochran@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f193.google.com ([209.85.215.193]:40833 "EHLO
        mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2389768AbeKPXqD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 16 Nov 2018 18:46:03 -0500
Received: by mail-pg1-f193.google.com with SMTP id z10so10629047pgp.7
        for <netdev@vger.kernel.org>; Fri, 16 Nov 2018 05:33:38 -0800 (PST)
In-Reply-To: <20181116021418.dhbw5cu4y56cfjls@localhost>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 2018-11-15 at 18:14 -0800, Richard Cochran wrote:
> On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote:
> > Sure, I would like to keep the debugfs entries for disabling freq
> > correction,and
> > reading the current scaled_ppm value.  I intend to use these to tune
> > anexternal
> > vcxo.  If there is a better way to do this, please let me know.
> 
> Yes, there is.  The external VCXO should be a proper PHC.  Then, with
> a minor change to the linuxptp stack (already in the pipe), you can
> just use that.
> 
> You should not disable frequency correction in the driver.  Leave that
> decision to the user space PTP stack.

Good to know, thanks.

> 
> > I would prefer to keep altera just to be consistent with the altera_tse
> > stuff,
> > and i intend to reusethis code for a 10GbE driver, so perhaps altera_tod to
> > reference the fpga ip name?
> 
> So the IP core is called "tod"?  Really?

yes, i am afraid so. "Time of Day"

--dalon

> 
> Thanks,
> Richard