From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E8E833AD81 for ; Thu, 26 Mar 2026 14:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774533942; cv=none; b=hhq5qysRRDyrTAuAH5B0me22ccBqbHcViEGVG4YkKwTaLl6qWx3zt+Wp2g/tf8490ehMyUjuM0xzckxYTmmxsSIw7ybrCh4lcZatpf3ZvmWw7mJYHLvQjolhWOlDI7cKX3ZfDdiN//LRM57Ka56NmoQpxaNAR5DlVKhAaciwgEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774533942; c=relaxed/simple; bh=+P/UaSSOrZzUsHGMRUaucczR4HHnEzzY5ibe0fyS/zY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MwzVJh4AWlESsHpE9smAiO4zaj5VpJwhanDTcU45POO+VE5RyaNb4EWhekRRj5VnN6+sosN4MB7z5a2F360GfOSeH2uCRXqSDHUJsAFC5ilWsdc/6CGOF0VLCO79GHDU+lTGgq5yWg9bOgT8QD5bl4Ox9ajCcHrhYnJmmPLqIeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fSBbFzzB; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fSBbFzzB" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b97ba4c2be2so132742666b.1 for ; Thu, 26 Mar 2026 07:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774533936; x=1775138736; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LHl7tocSnGmIBgBLm+xo8yjHEwMa3jnz1csUCNaWtac=; b=fSBbFzzBrm2ZZrbtwsqEJOXnicMSW0NLxvNaoSm7Pz75vsudXAh5U2LoGcSN3+Fc7b Asp7JVm1kUCvgdUYHYLyOJ/SWUWoLfAMLf3FSxsIflcLPcfgBTYCXvA4l9OunaxyxoAc mp20mLHw1iiskjRGdk/9nK3xpib0cZfrw585TarBJFakvs6mjVHpUmrNVHCV9Cawka6c RndZabTREjJQxwQzPMeo9ffyudlDRZu30qjs3nne+0s3DAbePln5zgBd4t9lXMXHueV6 3CzMf5EBRhywS7Q15v9rioDKJJnom5vnbxdqHGKjXGoXoZPURWXZOR/854LmAr9F7OXn /EjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774533936; x=1775138736; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LHl7tocSnGmIBgBLm+xo8yjHEwMa3jnz1csUCNaWtac=; b=RNzNG9InlawVqIr540owqGkMa0Oq4pHdB47kvgjFUyOhGIb8+1g+ykO0o6RvpgNYBr +DU7L3Hb1e36Q+7YTzjBGn25r8fz/vG9XdBelbCDWKjRYFd8ekFr03S0wep7Eq/7GhM0 D+FGhUsKedN+eLWkAIVZn1LXczYk7Iq2m34uYq9a7oH8Qw1pPce4c+PEsLVj6wbTaUot yQOHGaYD11Y4W0IXWi86Ask3LOPFMQp5+cNh2wFP3qPXv1zKdzQPB4LGXVOnBvBNqNuo bDGaeCs7Rhzy5xOFVluh/G9D+reG+1KngWmEaB2mqA/1Ku52NLoh4L3tfwFjGuwbAuEG 02kA== X-Forwarded-Encrypted: i=1; AJvYcCUbAsfwxsJd/+FMt1RchUBdBFcpkAeSk/N0/gSmWIi/2JC3qZcCfC1iG1h4Ivi+rBfi5oFIMnw=@vger.kernel.org X-Gm-Message-State: AOJu0YzaC6Kd1q23s6R3TdGCprMCBUTxvXQ7BDpuSn2Cz4npeVrwu4LU oSKivIHVRF+epOCLNa9qPJdIMu5UQZ3mVCh72OyGUA/sEoYueHaY7L6k X-Gm-Gg: ATEYQzy2RBVkhVEBRVzFse62FxUfu4ndkLYB5QKLiDSTKN8uoQipk6fiCzKla2xg3nA nzz4Oh0eWHiS9dvi5RyQFTWvnKPzbtl7hv0+HKdqlNZJMWqAlisrl2DLITtszzU1Aa+VJ+B/Qcx XxCZ5e1ySwO0a4SCYbC99aTg2P1oZSVQF0gmJnQgvmRxEhMmiaeXACKVja56gznJmMd/ppWKQnK yvW1JWRfqJSClP+NBUjWmGf4hRJFcPA4fuCA0djhLf1aPVnTXry0F0Q4YpAVaVpS2QmrN+xf43f wpMd4RBal3HdFeVLGh3t39+rSYV0mQKeB22T0uUvZg4C5V18BXLop05hpr2NTtyjG2lpcrOqodE qlbe2+jQp6tI5dsL5k2sI4GHWaMVCHkVldjnlwAb2g00YhIydBEvlx5HgaVyfhvipxKQDr87CeZ 6ozxTAIuvXt0rzfaAZpnDyhKiGCBP2kh4dYDAqGwMomnLAwHdTv9etkXqTwoDlpN61Ak64NcSrz +hreA== X-Received: by 2002:a17:907:c30e:b0:b97:bc8a:f45e with SMTP id a640c23a62f3a-b9a3f1665d2mr499473466b.1.1774533936094; Thu, 26 Mar 2026 07:05:36 -0700 (PDT) Received: from ?IPV6:2a02:a03f:a75e:9a00:41b0:4bee:eddb:bf6a? ([2a02:a03f:a75e:9a00:41b0:4bee:eddb:bf6a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b203eeeccsm127701166b.44.2026.03.26.07.05.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 07:05:35 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 15:05:34 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/ipv6: ioam6: prevent schema length wraparound in trace fill To: Pengpeng Hou , "David S . Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325074152.17064-1-pengpeng@iscas.ac.cn> Content-Language: en-US From: Justin Iurman In-Reply-To: <20260325074152.17064-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/25/26 08:41, Pengpeng Hou wrote: > ioam6_fill_trace_data() stores the schema contribution to the trace > length in a u8. With bit 22 enabled and the largest schema payload, > sclen becomes 1 + 1020 / 4, wraps from 256 to 0, and bypasses the > remaining-space check. __ioam6_fill_trace_data() then positions the > write cursor without reserving the schema area but still copies the > 4-byte schema header and the full schema payload, overrunning the trace > buffer. > > Keep sclen in an unsigned int so the remaining-space check and the write > cursor calculation both see the full schema length. > > Fixes: 8c6f6fa67726 ("ipv6: ioam: IOAM Generic Netlink API") ... should be: Fixes: 9ee11f0fff20 ("ipv6: ioam: Data plane support for Pre-allocated Trace") Respin needed? Otherwise, LGTM. Reviewed-by: Justin Iurman > Signed-off-by: Pengpeng Hou > --- > net/ipv6/ioam6.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ipv6/ioam6.c b/net/ipv6/ioam6.c > index b76f89d92e7b..3978773bec42 100644 > --- a/net/ipv6/ioam6.c > +++ b/net/ipv6/ioam6.c > @@ -708,7 +708,7 @@ static void __ioam6_fill_trace_data(struct sk_buff *skb, > struct ioam6_namespace *ns, > struct ioam6_trace_hdr *trace, > struct ioam6_schema *sc, > - u8 sclen, bool is_input) > + unsigned int sclen, bool is_input) > { > struct net_device *dev = skb_dst_dev(skb); > struct timespec64 ts; > @@ -939,7 +939,7 @@ void ioam6_fill_trace_data(struct sk_buff *skb, > bool is_input) > { > struct ioam6_schema *sc; > - u8 sclen = 0; > + unsigned int sclen = 0; > > /* Skip if Overflow flag is set > */