From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>, netdev@vger.kernel.org
Cc: shemminger@vyatta.com, dforster@brocade.com,
gospo@cumulusnetworks.com, ddutt@cumulusnetworks.com,
brian.haley@hp.com, horms@kernel.org, pabeni@redhat.com,
kuba@kernel.org, edumazet@google.com, davem@davemloft.net,
idosch@nvidia.com, dsahern@kernel.org
Subject: Re: [PATCH net 1/6] ipv6: fix error handling in disable_ipv6 sysctl
Date: Fri, 19 Jun 2026 11:33:53 +0200 [thread overview]
Message-ID: <a195341a-4678-46d0-b84d-50c2365e01ef@6wind.com> (raw)
In-Reply-To: <20260618162225.4588-2-fmancera@suse.de>
Le 18/06/2026 à 18:22, Fernando Fernandez Mancera a écrit :
> When writing to the disable_ipv6 sysctl, if proc_dointvec() fails to
> parse the input, it returns a negative error code. The current
> implementation is overwriting that error for write operations.
>
> This results in a silent failure, it returns a successful write although
> the configuration was not modified at all. When modifying the "all"
> variant it can also modify the configuration of existing interfaces to
> the wrong value.
>
> Fix this by checking the return value of proc_dointvec() and returning
> early on failure.
>
> Fixes: 56d417b12e57 ("IPv6: Add 'autoconf' and 'disable_ipv6' module parameters")
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2026-06-19 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 16:22 [PATCH net 0/6] ipv6: fix sysctl error handling and missing notifications Fernando Fernandez Mancera
2026-06-18 16:22 ` [PATCH net 1/6] ipv6: fix error handling in disable_ipv6 sysctl Fernando Fernandez Mancera
2026-06-19 9:33 ` Nicolas Dichtel [this message]
2026-06-18 16:22 ` [PATCH net 2/6] ipv6: fix error handling in ignore_routes_with_linkdown sysctl Fernando Fernandez Mancera
2026-06-19 9:34 ` Nicolas Dichtel
2026-06-18 16:22 ` [PATCH net 3/6] ipv6: fix error handling in forwarding sysctl Fernando Fernandez Mancera
2026-06-19 9:34 ` Nicolas Dichtel
2026-06-19 10:28 ` Fernando Fernandez Mancera
2026-06-19 13:04 ` Nicolas Dichtel
2026-06-18 16:22 ` [PATCH net 4/6] ipv6: fix error handling in disable_policy sysctl Fernando Fernandez Mancera
2026-06-19 9:35 ` Nicolas Dichtel
2026-06-18 16:22 ` [PATCH net 5/6] ipv6: reset value and position for proxy_ndp sysctl restart Fernando Fernandez Mancera
2026-06-19 9:58 ` Nicolas Dichtel
2026-06-19 10:09 ` Fernando Fernandez Mancera
2026-06-18 16:22 ` [PATCH net 6/6] ipv6: fix missing notification for ignore_routes_with_linkdown Fernando Fernandez Mancera
2026-06-19 10:02 ` Nicolas Dichtel
2026-06-19 16:42 ` [PATCH net 0/6] ipv6: fix sysctl error handling and missing notifications Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a195341a-4678-46d0-b84d-50c2365e01ef@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=ddutt@cumulusnetworks.com \
--cc=dforster@brocade.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=gospo@cumulusnetworks.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox