From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D13C43387 for ; Fri, 18 Jan 2019 14:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 403052086D for ; Fri, 18 Jan 2019 14:27:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zuc85yYN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727472AbfARO1z (ORCPT ); Fri, 18 Jan 2019 09:27:55 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36857 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbfARO1y (ORCPT ); Fri, 18 Jan 2019 09:27:54 -0500 Received: by mail-pf1-f193.google.com with SMTP id b85so6688163pfc.3; Fri, 18 Jan 2019 06:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0cGzHLsMoXeNfVbg39QEs92BZDRWpfdD6/55EHXUhao=; b=Zuc85yYN+VKV1YjXH5cXkfuGd0YPr5Jdzu2Z7IYXaBzy1nR0QIv/4SsKBP0RBdcZzU dGk7bawX/5AehGoW10xpRk2u2I7+mCE2nUtwAFJN9UQDf+5O1/lnZ9JPE8xdJtQOopFA MEDRdtXvR0ckKMFANf0jnzjr5VRfV9MeuxJlyVNoDzyXItQaHwER12uykolo1DXluQMa n/VJFW6dX2RQHECSIjMDaA3rTQxQP3gHaaPCWsbjVGkQRJb2q+eCf+rboX3oDCFCl0v8 uEnWxwZq+aAfgMOOW55HN1lJmqdt7UcC1pX8/xf3Ld8xXFgOfHwsLOiu2gjk+kCQVPT2 DNyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0cGzHLsMoXeNfVbg39QEs92BZDRWpfdD6/55EHXUhao=; b=auOOA2tiou2ilyjLmOOcy1UXRKNo+a5k9/lFf46RwmzshtdLcMIq4EL4BcDagT0JUF YDqHL0zqxSomo85WSOvQi1Uk26VhG6Qftj2InpkM7jzXPf7fNtXEF4NjusJxxI/eUAbI +XO8rghSx5FLxdduL1qChTXc6y2K3YOX5E4WYAU1lAlKngdflhxiNO4Tn1AE0q7F750Z 2Zu79bHitxaVxSRGSa4Yi9HDCTxnO4UX0fZmgXVBdHpYBEjxrWaQaImCNT9QKgfG3C8p sgkpeT9GVzw+YvOZXYaBIo0H+tZpiWDJqNMvOM4qZOMs7+vTV/sjaao8QXmxYI2eheXQ hkLg== X-Gm-Message-State: AJcUukfMLmPhQwP+8a/cqoL1o/kust9AZxxYoVlRaeFaGdMQ2atadwP7 eA3XuTiT9POxcJkB5qRSEWNJjEIq X-Google-Smtp-Source: ALg8bN79UHvHbRJMCnK+VQJ/T72wgMfKOtdw3k82OTEYOFKS5b3qMMJLuI+YSBJIWWhP1d8AR973Fw== X-Received: by 2002:a63:2bc4:: with SMTP id r187mr17779101pgr.306.1547821670594; Fri, 18 Jan 2019 06:27:50 -0800 (PST) Received: from ?IPv6:2601:284:8200:5cfb:9ce0:21bc:c124:a59c? ([2601:284:8200:5cfb:9ce0:21bc:c124:a59c]) by smtp.googlemail.com with ESMTPSA id u29sm6679430pgn.23.2019.01.18.06.27.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:27:49 -0800 (PST) Subject: Re: [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type To: Pablo Neira Ayuso , wenxu@ucloud.cn Cc: fw@strlen.de, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org References: <1547596431-31824-1-git-send-email-wenxu@ucloud.cn> <20190118142430.rsnru4hyrbsodobf@salvia> From: David Ahern Message-ID: Date: Fri, 18 Jan 2019 07:27:48 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190118142430.rsnru4hyrbsodobf@salvia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/18/19 7:24 AM, Pablo Neira Ayuso wrote: > > There is no other way to identify a vft device rather than this > string? The only l3mdev that exists if vrf, right? ipvlan uses some of the hooks. > > If there is no other alternative, we can just place this in the tree, > but probably it would be better to have a numeric way to identify a > vrf device? IFF_L3MDEV_MASTER and IFF_L3MDEV_SLAVE are used via netif_is_l3_master and netif_is_l3_slave in all of the code. This was done because of requests to not bleed 'vrf' all over core kernel code.