From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf-next 3/5] selftests/bpf: test_sockmap, fix test timeout Date: Fri, 18 May 2018 09:47:16 -0700 Message-ID: References: <20180518071753.4768-1-bhole_prashant_q7@lab.ntt.co.jp> <20180518071753.4768-4-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Shuah Khan , netdev@vger.kernel.org To: Prashant Bhole , Alexei Starovoitov , Daniel Borkmann Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:38382 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbeERQrU (ORCPT ); Fri, 18 May 2018 12:47:20 -0400 Received: by mail-pl0-f68.google.com with SMTP id c11-v6so4905973plr.5 for ; Fri, 18 May 2018 09:47:20 -0700 (PDT) In-Reply-To: <20180518071753.4768-4-bhole_prashant_q7@lab.ntt.co.jp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/18/2018 12:17 AM, Prashant Bhole wrote: > In order to reduce runtime of tests, recently timout for select() call > was reduced from 1sec to 10usec. This was causing many tests failures. > It was caught with failure handling commits in this series. > > Restoring the timeout from 10usec to 1sec > > Fixes: a18fda1a62c3 ("bpf: reduce runtime of test_sockmap tests") > Signed-off-by: Prashant Bhole > --- Whats the runtime for the entire test suite after this? I agree I was probably to aggressive in setting this but on the other hand I was trying to avoid letting the test run for minutes. .John