From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>
Cc: Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] net: phylink: support for link gpio interrupt
Date: Mon, 20 May 2019 11:22:21 -0700 [thread overview]
Message-ID: <a1bde03d-cd12-3f77-8e93-eed276f2bbdb@gmail.com> (raw)
In-Reply-To: <E1hSk6y-0000vs-Pj@rmk-PC.armlinux.org.uk>
On 5/20/19 8:22 AM, Russell King wrote:
> Add support for using GPIO interrupts with a fixed-link GPIO rather than
> polling the GPIO every second and invoking the phylink resolution. This
> avoids unnecessary calls to mac_config().
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Just one comment, see below:
[snip]
> - if (pl->link_an_mode == MLO_AN_FIXED && !IS_ERR(pl->link_gpio))
> - del_timer_sync(&pl->link_poll);
> + del_timer_sync(&pl->link_poll);
Removing a timer that was only set-up if pl->link_an_mode ==
MLO_AN_FIXED probably does not hurt, but this breaks symmetry a bit here.
--
Florian
next prev parent reply other threads:[~2019-05-20 18:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 15:21 [PATCH net-next 0/4] phylink/sfp updates Russell King - ARM Linux admin
2019-05-20 15:22 ` [PATCH net-next 1/4] net: phylink: support for link gpio interrupt Russell King
2019-05-20 18:22 ` Florian Fainelli [this message]
2019-05-20 18:31 ` Russell King - ARM Linux admin
2019-05-20 15:22 ` [PATCH net-next 2/4] net: phy: allow Clause 45 access via mii ioctl Russell King
2019-05-20 18:23 ` Florian Fainelli
2019-05-20 15:22 ` [PATCH net-next 3/4] net: sfp: add mandatory attach/detach methods for sfp buses Russell King
2019-05-20 18:24 ` Florian Fainelli
2019-05-20 15:22 ` [PATCH net-next 4/4] net: sfp: remove sfp-bus use of netdevs Russell King
2019-05-20 18:25 ` Florian Fainelli
2019-05-20 15:40 ` [PATCH net-next 0/4] phylink/sfp updates Vladimir Oltean
2019-05-22 17:34 ` David Miller
2019-05-28 9:56 ` [PATCH net-next 0/5] " Russell King - ARM Linux admin
2019-05-28 9:57 ` [PATCH net-next 1/5] net: phylink: remove netdev from phylink mii ioctl emulation Russell King
2019-05-28 15:19 ` Andrew Lunn
2019-05-28 9:57 ` [PATCH net-next 2/5] net: phylink: support for link gpio interrupt Russell King
2019-05-28 10:02 ` Russell King - ARM Linux admin
2019-05-29 21:21 ` David Miller
2019-05-28 9:57 ` [PATCH net-next 3/5] net: phy: allow Clause 45 access via mii ioctl Russell King
2019-05-28 12:54 ` Vladimir Oltean
2019-05-28 13:27 ` Russell King - ARM Linux admin
2019-05-28 15:31 ` Andrew Lunn
2019-05-28 9:57 ` [PATCH net-next 4/5] net: sfp: add mandatory attach/detach methods for sfp buses Russell King
2019-05-28 15:21 ` Andrew Lunn
2019-05-28 9:57 ` [PATCH net-next 5/5] net: sfp: remove sfp-bus use of netdevs Russell King
2019-05-28 15:21 ` Andrew Lunn
2019-05-31 19:39 ` [PATCH net-next 0/5] phylink/sfp updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1bde03d-cd12-3f77-8e93-eed276f2bbdb@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).